code restructure

[zrx1200]

Public Sub End_of_day_color_row()
     Dim LastRowColA As Integer
      Dim worksht As String
         LastRowColA = Range("B65536").End(xlUp).row

      With Worksheets("Newidea").Range("S16")
           .Range(.Cells(LastRowColA, 2), _
            .Cells(LastRowColA, 1)).EntireRow.Interior.Color = RGB(255, 140, 0)
      End With
End Sub

I wish to color last none used row orange at the end of day. Just need to get this to work correctly. Its picking last row correctly but can get entire row to color?

 

[Michael M]

Maybe this...

Public Sub End_of_day_color_row()
Dim LastRowColA As Long
LastRowColA = Range("B65536").End(xlUp).Row
Worksheets("Newidea").Rows(LastRowColA).Interior.Color = RGB(255, 140, 0)
End Sub

 

[zrx1200]

Latest revision. Thanks Sir!

Public Sub End_of_day_color_row()
        Dim LastRowColA As Long
        Dim worksht As String
          worksht = Worksheets("Newidea").Range("S16")
     LastRowColA = Range("B65536").End(xlUp).row
       Worksheets(worksht).Rows(LastRowColA).Offset(1, 0).Interior.Color = RGB(255, 140, 0)
End Sub

 

[Michael M]

there is no need for Range("S16")

Public Sub End_of_day_color_row()
Dim LastRowColA As Long, worksht As Worksheet
Set worksht = Worksheets("Newidea")
LastRowColA = Range("B65536").End(xlUp).Row
worksht.Rows(LastRowColA).Offset(1, 0).Interior.Color = RGB(255, 140, 0)
End Sub

 

[Rick Rothstein]

there is no need for Range("S16")

Public Sub End_of_day_color_row()
Dim LastRowColA As Long, worksht As Worksheet
Set worksht = Worksheets("Newidea")
LastRowColA = Range("B65536").End(xlUp).Row
worksht.Rows(LastRowColA)[B][COLOR="#FF0000"].Offset(1, 0)[/COLOR][/B].Interior.Color = RGB(255, 140, 0)
End Sub

There is no need for the Offset function call either... since we have the last row number in a variable, we can just add one to it directly...

worksht.Rows(LastRowColA + 1).Interior.Color = RGB(255, 140, 0)

 

[Michael M]

I agree Rick...