MrExcel Message Board

Go Back   MrExcel Message Board > Question Forums > Excel Questions
Reload this Page vba weird?
Register FAQ Calendar Search Today's Posts Mark Forums Read SearchMrExcel Online StoreLost Password

Excel Questions All Excel/VBA questions - formulas, macros, pivot tables, general help, etc. Please post to this forum in English only.

Reply
 
Thread Tools Display Modes
Old Mar 3rd, 2002, 11:07 AM   #1
Guest
 
Posts: n/a
Default
i have created this code, and for some reason it spawns copies of the worksheet that the first IF selects (January, February etc). If anyone can help, i'd appreciate it.

Private Sub ComboBox2_AfterUpdate()
Dim Month1 As Object
Dim LUList As Object
If Range("MonthChoice") = "January" Then
Sheets("January").Select
ElseIf Range("MonthChoice") = "February" Then
Sheets("February").Select
ElseIf Range("MonthChoice") = "March" Then
Sheets("March").Select
ElseIf Range("MonthChoice") = "April" Then
Sheets("April").Select
ElseIf Range("MonthChoice") = "May" Then
Sheets("May").Select
ElseIf Range("MonthChoice") = "June" Then
Sheets("June").Select
ElseIf Range("MonthChoice") = "July" Then
Sheets("July").Select
ElseIf Range("MonthChoice") = "August" Then
Sheets("August").Select
ElseIf Range("MonthChoice") = "September" Then
Sheets("September").Select
ElseIf Range("MonthChoice") = "October" Then
Sheets("October").Select
ElseIf Range("MonthChoice") = "November" Then
Sheets("November").Select
ElseIf Range("MonthChoice") = "December" Then
Sheets("December").Select
End If
If Range("MonthChoice") = "January" Then
Set Month1 = Range("January1")
ElseIf Range("MonthChoice") = "February" Then
Set Month1 = Range("February1")
ElseIf Range("MonthChoice") = "March" Then
Set Month1 = Range("March1")
ElseIf Range("MonthChoice") = "April" Then
Set Month1 = Range("April1")
ElseIf Range("MonthChoice") = "May" Then
Set Month1 = Range("May1")
ElseIf Range("MonthChoice") = "June" Then
Set Month1 = Range("June1")
ElseIf Range("MonthChoice") = "July" Then
Set Month1 = Range("July1")
ElseIf Range("MonthChoice") = "August" Then
Set Month1 = Range("August1")
ElseIf Range("MonthChoice") = "September" Then
Set Month1 = Range("September1")
ElseIf Range("MonthChoice") = "October" Then
Set Month1 = Range("October1")
ElseIf Range("MonthChoice") = "November" Then
Set Month1 = Range("November1")
ElseIf Range("MonthChoice") = "December" Then
Set Month1 = Range("December1")
ElseIf Range("MonthChoice") = "" Then
answer = MsgBox("You have not selected a Month", vbOKOnly, "ProComp")
End
End If
For Each LUList In Month1
If LUList = Range("DateChoice") Then
LUList.Offset(0, 1).Range("A1").Copy
ActiveSheet.Copy
Sheets("Lists").Select
Range("Taken").Select
ActiveCell.Paste
Else
End If
Next
End Sub


Sometimes it doesnt spawn worksheets. But instead the "ActiveCell.Paste" line doesn't work either. Does anyone know why not?
  Reply With Quote
Old Mar 3rd, 2002, 11:09 AM   #2
Guest
 
Posts: n/a
Default
Also. Does anyone know if the IF sections can be shortened?

Any help is appreciated. Thanks
  Reply With Quote
Old Mar 3rd, 2002, 11:33 AM   #3
Mark O'Brien
MrExcel MVP
 
Mark O'Brien's Avatar
 
Join Date: Feb 2002
Location: Columbus, OH, USA
Posts: 3,519
Default
Quote:
Private Sub ComboBox2_AfterUpdate()
Dim Month1 As Object
Dim LUList As Object
If Range("MonthChoice") = "January" Then
Sheets("January").Select
ElseIf Range("MonthChoice") = "February" Then
Sheets("February").Select
ElseIf Range("MonthChoice") = "March" Then
Sheets("March").Select
ElseIf Range("MonthChoice") = "April" Then
Sheets("April").Select
ElseIf Range("MonthChoice") = "May" Then
Sheets("May").Select
ElseIf Range("MonthChoice") = "June" Then
Sheets("June").Select
ElseIf Range("MonthChoice") = "July" Then
Sheets("July").Select
ElseIf Range("MonthChoice") = "August" Then
Sheets("August").Select
ElseIf Range("MonthChoice") = "September" Then
Sheets("September").Select
ElseIf Range("MonthChoice") = "October" Then
Sheets("October").Select
ElseIf Range("MonthChoice") = "November" Then
Sheets("November").Select
ElseIf Range("MonthChoice") = "December" Then
Sheets("December").Select
End If
If Range("MonthChoice") = "January" Then
Set Month1 = Range("January1")
ElseIf Range("MonthChoice") = "February" Then
Set Month1 = Range("February1")
ElseIf Range("MonthChoice") = "March" Then
Set Month1 = Range("March1")
ElseIf Range("MonthChoice") = "April" Then
Set Month1 = Range("April1")
ElseIf Range("MonthChoice") = "May" Then
Set Month1 = Range("May1")
ElseIf Range("MonthChoice") = "June" Then
Set Month1 = Range("June1")
ElseIf Range("MonthChoice") = "July" Then
Set Month1 = Range("July1")
ElseIf Range("MonthChoice") = "August" Then
Set Month1 = Range("August1")
ElseIf Range("MonthChoice") = "September" Then
Set Month1 = Range("September1")
ElseIf Range("MonthChoice") = "October" Then
Set Month1 = Range("October1")
ElseIf Range("MonthChoice") = "November" Then
Set Month1 = Range("November1")
ElseIf Range("MonthChoice") = "December" Then
Set Month1 = Range("December1")
ElseIf Range("MonthChoice") = "" Then
answer = MsgBox("You have not selected a Month", vbOKOnly, "ProComp")
End
End If
For Each LUList In Month1
If LUList = Range("DateChoice") Then
LUList.Offset(0, 1).Range("A1").Copy
ActiveSheet.Copy
Sheets("Lists").Select
Range("Taken").Select
ActiveCell.Paste
Else
End If
Next
End Sub
To answer your second quesion first (this may solve the problem, there are two ways I see to remove all of the "If" statements.

The first way is using select case:





Select Case MonthChoice



Case January

... your code here



Case December

... etc



Case Else

...This is where the error code for nonselection would go



End Select


However it may be easier to just do something like this:



  

    If Range("MonthChoice") = "" Then

      answer = MsgBox("You have not selected a Month", vbOKOnly, "ProComp")

    Else

      Sheets(Range("MonthChoice").Value).Select

      Set Month1 = Range((Range("MonthChoice").Value) & "1")

    End If


I'm not quite sure of your syntax, but hopefully you can mess around with this to make it work.

HTH
Mark O'Brien is offline   Reply With Quote
Old Mar 3rd, 2002, 11:36 AM   #4
Guest
 
Posts: n/a
Default
thanks i'll give it a try
  Reply With Quote
Old Mar 3rd, 2002, 12:16 PM   #5
Guest
 
Posts: n/a
Default
Thanks. That If code worked. However, i'm still getting the spawning workbook problem though
  Reply With Quote
Old Mar 3rd, 2002, 12:18 PM   #6
Guest
 
Posts: n/a
Default
My new code is this, if anyone can help

Private Sub ComboBox2_AfterUpdate()
Dim Month1 As Object
Dim LUList As Object
If Range("MonthChoice") = "" Then
answer = MsgBox("You have not selected a Month", vbOKOnly, "ProComp")
Else
Sheets(Range("MonthChoice").Value).Select
End If

If Range("MonthChoice") = "" Then
answer = MsgBox("You have not selected a Month", vbOKOnly, "ProComp")
Else
Sheets(Range("MonthChoice").Value).Select
Set Month1 = Range((Range("MonthChoice").Value) & "1")
End If
For Each LUList In Month1
If LUList = Range("DateChoice") Then
LUList.Offset(0, 1).Range("A1").Copy
ActiveSheet.Copy
End If
Next
Sheets("Lists").Select
Range("Taken").Select
ActiveCell.Paste
End Sub
  Reply With Quote
Old Mar 3rd, 2002, 12:20 PM   #7
Guest
 
Posts: n/a
Default
what i want the code to actually do. is to move to a sheet (user selected), go down a list of numbers to find one (user selected), and copy the cell to the right of that number. move to another sheet. and paste into another cell
  Reply With Quote
Old Mar 4th, 2002, 01:16 PM   #8
Mark O'Brien
MrExcel MVP
 
Mark O'Brien's Avatar
 
Join Date: Feb 2002
Location: Columbus, OH, USA
Posts: 3,519
Default
Quote:
On 2002-03-03 11:18, Anonymous wrote:
My new code is this, if anyone can help

Private Sub ComboBox2_AfterUpdate()
Dim Month1 As Object
Dim LUList As Object
If Range("MonthChoice") = "" Then
answer = MsgBox("You have not selected a Month", vbOKOnly, "ProComp")
Else
Sheets(Range("MonthChoice").Value).Select
End If

If Range("MonthChoice") = "" Then
answer = MsgBox("You have not selected a Month", vbOKOnly, "ProComp")
Else
Sheets(Range("MonthChoice").Value).Select
Set Month1 = Range((Range("MonthChoice").Value) & "1")
End If
For Each LUList In Month1
If LUList = Range("DateChoice") Then
LUList.Offset(0, 1).Range("A1").Copy
ActiveSheet.Copy
End If
Next
Sheets("Lists").Select
Range("Taken").Select
ActiveCell.Paste
End Sub
What's that "ActiveSheet.Copy" there for? This could be the culprit.
__________________
Mark O'Brien

Columbus Ohio Celtic Supporters Club
Mark O'Brien is offline   Reply With Quote
Old Mar 4th, 2002, 01:24 PM   #9
waggy30
New Member
 
Join Date: Mar 2002
Location: England
Posts: 46
Default
thanks. i changed it to activecell and it worked
waggy30 is offline   Reply With Quote
Reply

Bookmarks

« Previous Thread | Next Thread »
Thread Tools
Display Modes
Linear Mode Linear Mode

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts
BB code is On
Smilies are On
[IMG] code is On
HTML code is On
Forum Jump


All times are GMT -4. The time now is 07:16 AM.

Contact Us - Ask Mr. Excel - Tips and Solutions for Excel - Archive - Privacy Statement - Terms of Service - Top

Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2012, vBulletin Solutions, Inc.
All contents Copyright 1998-2012 by MrExcel Consulting.
diabetic desserts recipes recipes Diabetic Soups Holiday Pizza Recipes Popcorn Recipes Recipes For Microwave Pasta Recipes Casserole Recipes Chili Recipes Curry Recipes Crockpot Recipes Apples Recipes Bread Recipes Vegetarian Recipes Vegetable recipes Desserts Recipes Appetizers Ethnic Recipes Meat Dishes Barbecue Recipes Sauces Recipes Marinade Recipes Low Fat Recipes Frugal Gourmet Kitchen Classics Recipes On The Grill Cook Books Seafood Recipes Cajun Recipes Breads Low Fat Low Fat Breads Bread Machine Recipes Yeast Breads Quick Breads Fat Free Vegetarian Salad Recipes Eggplant Recipes Radish Recipes Tomato Recipes Jalapeno Recipes Potato Recipes Lettuce Recipes Cabbage Recipes Beans Ambrosia Recipes Biscotti Recipes Desserts Low Fat Cookie Recipes Cheesecake Recipes Cake Recipes Pie Recipes Muffin Recipes Custard Recipes Best Appetizers Appetizers Low Fat Salsa Recipes Dip Recipes International Recipes Afghan Recipes Alaska Recipes French Recipes German Recipes Greek Recipes Italian Recipes Spanish Recipes Thai Recipes Korean Recipes Chinese Recipes Mexican Recipes Indian Recipes Beef Recipes Pork Pork & Ham Pork Butts Pork Chop Recipes Pork Ribs Rulled Pork Poultry Recipes Stews Recipes Ground Beef Barbecue Grill Barbecue Smoker All Purpose Sauce BBQ Sauce Barbecue Sauce Carolina BBQ Sauce Pickle Recipes Marinades Smoking Low Fat Appetizers & Dips Low Fat Breakfast Low Fat Cakes Low Fat Cheesecakes Low Fat Cookies Low Fat Desserts Low Fat Fish & Seafood Low Fat Meats Low Fat Pasta Low Fat Pies Low Fat Salads Low Fat Sandwiches Low Fat Sauces & Condiments Low Fat Sides Low Fat Soups Low Fat Vegetarian Baker's Dozen Taste of Home Recipe Book Bon Appetit Cookbook Blacktie Cookbook Buster Cook Book Cookbook USA Cook Book Cook Book Sara's Cookbook Sara's Cookbook Appetizers and Dips Poultry recipes Diabetic recipes Holiday recipes Miscellaneous recipes 110 recipes 1986 Usenet cookbook 2900 recipes Cyberrealm recipes Great sysops of world Specialty recipes Ceideburg recipes Cheese recipes Chili recipes Fruits recipes Garlic recipes Great chefs of NY Londontowne recipes Raisins recipes Recipes for kids US Food Vegetarian recipes Bread recipes Drinks Meat Dishes Brisket recipes Caribou recipes Chicken recipes Filet mignons recipes Pork recipes Swordfish recipes Turkey recipes Pasta recipes Uncategorized recipes Ethnic recipes Canada recipes English recipes Ethiopia recipes Germany recipes Greece recipes Mexican recipes Philippines recipes Welsh recipes Microwave recipes Soups recipes Vegetable recipes Asparagus recipes Barley recipes Brown rice recipes Lentil recipes Mushrooms recipes Salads recipes Wild rice Desserts recipes Cakes recipes Chocolate recipes Cookies recipes Ice cream recipes