Help with Do While Loop

[Adrae]

the following code should keep looking until FirstValue does not equal SecondValue or until the cell in column A of sheet2 is empty.

It isn't working. I'm a bit of a novice and the book I have is not helping to any great extent.

Anything you can suggest is greatly appreciated.

Sub ProductServiceBoth()
Dim FirstValue, SecondValue As String
Dim Cel As Range
For Each Cel In Selection
Set c = Worksheets("Sheet2").Columns("A:A").Find(Worksheets("Sheet1").Range(Cel.Address).Value, LookIn:=xlWhole)
FirstValue = Worksheets("Sheet2").Range(c.Address).Offset(0, 3).Value
Set b = Worksheets("Sheet2").Columns("A:A").FindNext(c)
SecondValue = Worksheets("Sheet2").Range(b.Address).Offset(0, 3).Value
If FirstValue <> SecondValue Then
Worksheets("Sheet1").Range(Cel.Address).Offset(0, 3).Value = "Both"
Else
Do While FirstValue = SecondValue
Set b = Worksheets("Sheet2").Columns("A:A").FindNext(c)
SecondValue = Worksheets("Sheet2").Range(b.Address).Offset(0, 3).Value
If FirstValue <> SecondValue Then
Worksheets("Sheet1").Range(Cel.Address).Offset(0, 3).Value = "Both"
Else
End If
Loop
End If
Next Cel
End Sub

Thanks

[daleyman]

this does seem a little overcomplicated, what is it you are trying to do?

[Adrae]

Please see my previous post in which I explain, if a bit unclearly, what I am trying to do. Any help at all would be greatly appreciated. I'll be dealing with some 45,000 records (rows). Thanks

http://www.mrexcel.com/board/viewtop...4075&forum=2&8

[Al Chara]

I answered your first post, like I said, its not clean, because I didn't feel like starting over. Hope you are happy with it.

[Joe Was]

I may not have understood what you were trying to do, it would help if you said what you had as data and what you wanted to happen!

This code will put a "Both" to the right of a matched value from sheet1 and sheet2 on sheet1. JSW

Sub ProductServiceBoth()
Dim FirstValue, SecondValue As String
Dim Cel As Range

For Each Cel In Worksheets("Sheet1").Range("A:A")
FirstValue = Worksheets("Sheet1").Range(Cel.Address).Value
SecondValue = Worksheets("Sheet2").Range(Cel.Address).Value

If IsEmpty(FirstValue) Then GoTo Kill

If FirstValue = SecondValue Then
Worksheets("Sheet1").Range(Cel.Address).Offset(0, 1).Value = "Both"
End If
Next Cel
Kill:
End
End Sub