MrExcel Message Board

Go Back   MrExcel Message Board > Question Forums > Excel Questions

Excel Questions All Excel/VBA questions - formulas, macros, pivot tables, general help, etc. Please post to this forum in English only.

Reply
 
Thread Tools Display Modes
Old May 22nd, 2002, 06:16 PM   #1
dfein
New Member
 
Join Date: May 2002
Location: John Wiley
Posts: 15
Default

I have a workbook with code in "thisworkbook", there is a declaration Public ebv_codebook As String and in openworkbook event it gets set. However as soon as the openworkbook event is done the variable is reset to "" (ie blank). What is going on? Isn't the scope of a public variable on the top of a module the life of the module, ie until its gets closed?
Thanks
David Fein
dfein is offline   Reply With Quote
Old May 22nd, 2002, 06:47 PM   #2
Mark O'Brien
MrExcel MVP
 
Mark O'Brien's Avatar
 
Join Date: Feb 2002
Location: Columbus, OH, USA
Posts: 3,519
Default


Are you trying to use this variable outwith the workbook object? The workbook module is a private module. This means that you cannot see a variable from outside of the module. Try declaring the variable in a standard module that contains a subroutine that is called by the Open event.

OR

Global variables are very messy, you would be better off declaring this as a constant or if it truly is a variable, then pass the variable between subroutines and functions that use the variable.

HTH (cuz I'm tired and may be speaking in slabbers)
Mark O'Brien is offline   Reply With Quote
Old May 22nd, 2002, 07:08 PM   #3
Ivan F Moala
MrExcel MVP
 
Ivan F Moala's Avatar
 
Join Date: Feb 2002
Location: Auckland, New Zealand
Posts: 4,209
Default

Quote:
On 2002-05-22 17:16, dfein wrote:
I have a workbook with code in "thisworkbook", there is a declaration Public ebv_codebook As String and in openworkbook event it gets set. However as soon as the openworkbook event is done the variable is reset to "" (ie blank). What is going on? Isn't the scope of a public variable on the top of a module the life of the module, ie until its gets closed?
Thanks
David Fein
Hi David
A variable retains its value only over the course of the procedures
exercution. Declaring a variable as Public does NOT mean it holds
its value it just means that it is is visible to all procedures
in all modules in a directly referencing project, unless you have a
Option Private Module in the Generals section of your a Module.
The value of a variable may change over its lifetime, but it retains
some value (wether that be it's initialized value of 0,"" Empty or
what ever depending on the variable type declared
eg. A numeric variable is initialized to zero, a variable-length
string is initialized to a zero-length string (""), and a fixed-length
string is filled with the character represented by the ASCII character
code 0, or Chr(0). Variant variables are initialized to Empty.
Each element of a user-defined type variable is initialized as
if it were a separate variable.
So in your case the variable looses scope
after the workbook open is run.

One way around this as my friend Mark O has let us know is to
create a Class Module;

Eg.
1) Insert Class Module [Class1] = default name but you can change it
as long as your reference it by name.
2) Place this code in;



Option Explicit

Public vMyValue As Variant

'
'
'In a Std Module place this code;
'
'

Dim oClass As Class1

Public Sub main()

If oClass Is Nothing Then
Set oClass = New Class1
oClass.vMyValue = InputBox("Enter a value")
End If

MsgBox oClass.vMyValue

End Sub

'
'
'
Run the routine and see what happens.




__________________
Kind Regards,
Ivan F Moala From the City of Sails
Ivan F Moala is offline   Reply With Quote
Old May 22nd, 2002, 07:19 PM   #4
Mark O'Brien
MrExcel MVP
 
Mark O'Brien's Avatar
 
Join Date: Feb 2002
Location: Columbus, OH, USA
Posts: 3,519
Default

Ivan, I see you've added "Option Explicit"

http://www.mrexcel.com/board/viewtop...c=3544&forum=2

I thought those variable names sounded familiar.
__________________
Mark O'Brien

Columbus Ohio Celtic Supporters Club
Mark O'Brien is offline   Reply With Quote
Old May 22nd, 2002, 07:34 PM   #5
Ivan F Moala
MrExcel MVP
 
Ivan F Moala's Avatar
 
Join Date: Feb 2002
Location: Auckland, New Zealand
Posts: 4,209
Default

Quote:
On 2002-05-22 18:19, Mark O'Brien wrote:
Ivan, I see you've added "Option Explicit"

http://www.mrexcel.com/board/viewtop...c=3544&forum=2

I thought those variable names sounded familiar.
Mark, I like this code so much I copied it
and made it my own !! by putting Option explicit


__________________
Kind Regards,
Ivan F Moala From the City of Sails
Ivan F Moala is offline   Reply With Quote
Old May 22nd, 2002, 07:39 PM   #6
Mark O'Brien
MrExcel MVP
 
Mark O'Brien's Avatar
 
Join Date: Feb 2002
Location: Columbus, OH, USA
Posts: 3,519
Default

Thank goodness I didn't show you the "proper" method using public properties and "Property Let", "Property Get".

On a third thought, my mate Andrew might be from Christchurch.
__________________
Mark O'Brien

Columbus Ohio Celtic Supporters Club
Mark O'Brien is offline   Reply With Quote
Old May 22nd, 2002, 07:44 PM   #7
Ivan F Moala
MrExcel MVP
 
Ivan F Moala's Avatar
 
Join Date: Feb 2002
Location: Auckland, New Zealand
Posts: 4,209
Default

Quote:
On 2002-05-22 18:39, Mark O'Brien wrote:
Thank goodness I didn't show you the "proper" method using public properties and "Property Let", "Property Get".

On a third thought, my mate Andrew might be from Christchurch.
Your Too late I already have these properties
down pat

Yes I know an Andrew from C/C !!
__________________
Kind Regards,
Ivan F Moala From the City of Sails
Ivan F Moala is offline   Reply With Quote
Reply

Bookmarks

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is On

Forum Jump


All times are GMT -4. The time now is 07:20 PM.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2012, vBulletin Solutions, Inc.
All contents Copyright 1998-2012 by MrExcel Consulting.
diabetic desserts recipes recipes Diabetic Soups Holiday Pizza Recipes Popcorn Recipes Recipes For Microwave Pasta Recipes Casserole Recipes Chili Recipes Curry Recipes Crockpot Recipes Apples Recipes Bread Recipes Vegetarian Recipes Vegetable recipes Desserts Recipes Appetizers Ethnic Recipes Meat Dishes Barbecue Recipes Sauces Recipes Marinade Recipes Low Fat Recipes Frugal Gourmet Kitchen Classics Recipes On The Grill Cook Books Seafood Recipes Cajun Recipes Breads Low Fat Low Fat Breads Bread Machine Recipes Yeast Breads Quick Breads Fat Free Vegetarian Salad Recipes Eggplant Recipes Radish Recipes Tomato Recipes Jalapeno Recipes Potato Recipes Lettuce Recipes Cabbage Recipes Beans Ambrosia Recipes Biscotti Recipes Desserts Low Fat Cookie Recipes Cheesecake Recipes Cake Recipes Pie Recipes Muffin Recipes Custard Recipes Best Appetizers Appetizers Low Fat Salsa Recipes Dip Recipes International Recipes Afghan Recipes Alaska Recipes French Recipes German Recipes Greek Recipes Italian Recipes Spanish Recipes Thai Recipes Korean Recipes Chinese Recipes Mexican Recipes Indian Recipes Beef Recipes Pork Pork & Ham Pork Butts Pork Chop Recipes Pork Ribs Rulled Pork Poultry Recipes Stews Recipes Ground Beef Barbecue Grill Barbecue Smoker All Purpose Sauce BBQ Sauce Barbecue Sauce Carolina BBQ Sauce Pickle Recipes Marinades Smoking Low Fat Appetizers & Dips Low Fat Breakfast Low Fat Cakes Low Fat Cheesecakes Low Fat Cookies Low Fat Desserts Low Fat Fish & Seafood Low Fat Meats Low Fat Pasta Low Fat Pies Low Fat Salads Low Fat Sandwiches Low Fat Sauces & Condiments Low Fat Sides Low Fat Soups Low Fat Vegetarian Baker's Dozen Taste of Home Recipe Book Bon Appetit Cookbook Blacktie Cookbook Buster Cook Book Cookbook USA Cook Book Cook Book Sara's Cookbook Sara's Cookbook Appetizers and Dips Poultry recipes Diabetic recipes Holiday recipes Miscellaneous recipes 110 recipes 1986 Usenet cookbook 2900 recipes Cyberrealm recipes Great sysops of world Specialty recipes Ceideburg recipes Cheese recipes Chili recipes Fruits recipes Garlic recipes Great chefs of NY Londontowne recipes Raisins recipes Recipes for kids US Food Vegetarian recipes Bread recipes Drinks Meat Dishes Brisket recipes Caribou recipes Chicken recipes Filet mignons recipes Pork recipes Swordfish recipes Turkey recipes Pasta recipes Uncategorized recipes Ethnic recipes Canada recipes English recipes Ethiopia recipes Germany recipes Greece recipes Mexican recipes Philippines recipes Welsh recipes Microwave recipes Soups recipes Vegetable recipes Asparagus recipes Barley recipes Brown rice recipes Lentil recipes Mushrooms recipes Salads recipes Wild rice Desserts recipes Cakes recipes Chocolate recipes Cookies recipes Ice cream recipes