Add to external Excel database

COwen

Board Regular
Joined
Feb 27, 2020
Messages
225
Office Version
  1. 365
  2. 2019
  3. 2016
Platform
  1. Windows
I am trying to add to add date from a Userform on one workbook to another workbook that holds my data. Here is the code I have currently:

VBA Code:
Private Sub imgGenerate_Click()
Dim wb As Workbook
Dim ws As Worksheet
Dim x As Integer
With Sheet12 'Worksheets("Sample Router")
    .Range("INV").Value = cntrl5.Value
    .Range("SON").Value = cntrl6.Value
    .Range("Cust").Value = cntrl8.Value
    .Range("IDate").Value = cntrl7.Value
    .Range("EDate").Value = cntrl4.Value
    .Range("RouterX").Value = (.Range("RouterX").Value + 1)
    '.Range("A1:O62").PrintOut
End With
On Error GoTo Err
Application.ScreenUpdating = False

    With Application
        .DisplayAlerts = False
        .Visible = False
        .ScreenUpdating = False
    End With
    
    Set wb = Workbooks.Open(Filename:="C:\Users\caleb.owen\Documents\Cordial FileTracker tobezip\XLDataBaseforCordial.xlsm")
    Set ws = wb.Worksheets("Sheet1")
    
    'find first empty row in database
    'iRow = ws.Cells(Rows.Count, 1).End(xlUp).Offset(1, 0).Row
    iRow = ws.Cells(Rows.Count, 1).End(xlUp).Offset(1, 0).Row
    'copy the data to the database
    ws.Cells(iRow, 0).Value = Me.cntrl1.Value
    ws.Cells(iRow, 2).Value = Me.cntrl2.Value
    ws.Cells(iRow, 3).Value = Me.cntrl5.Value
    ws.Cells(iRow, 4).Value = Me.cntrl6.Value
    ws.Cells(iRow, 5).Value = Me.cntrl7.Value
    ws.Cells(iRow, 6).Value = Me.cntrl8.Value
    ws.Cells(iRow, 7).Value = Me.cntrl4.Value
    ws.Cells(iRow, 8).Value = Me.cntrl9.Value
    ws.Cells(iRow, 9).Value = Me.cntrl3.Value
    ws.Cells(iRow, 10).Value = Me.cntrl10.Value
Err:
    Workbooks("XLDataBaseforCordial.xlsm").Close True
    
With Sheet12 'Worksheets("Sample Router")
    .Range("INV").Value = ""
    .Range("SON").Value = ""
    .Range("Cust").Value = ""
    .Range("IDate").Value = ""
    .Range("EDate").Value = ""
End With
cntrl2.Value = Sheet12.Range("RouterV").Value
For x = 5 To 10
Me.Controls("cntrl" & x).Value = ""
Next x
End Sub

It is not populating correctly at all. It will only add the data to the first line then it will stop.
 
In that case there is something else going on, because when you get to that line it should simply cause an error & bring up the normal error message box as you showed in post#5
 
Upvote 0

Excel Facts

Round to nearest half hour?
Use =MROUND(A2,"0:30") to round to nearest half hour. Use =CEILING(A2,"0:30") to round to next half hour.
I am unsure what that something is.
 
Upvote 0
You told me not to share workbooks in the past, so you will have to tell me how you would like me to share.

P.S. the tone of the above comment sounds harsh...I was not being snarky intentionally, simply asking your preference.
 
Upvote 0
You can either share it the same way you have in the past, or you can upload to somewhere like OneDrive, mark for sharing & post the link to the thread.
You told me not to share workbooks in the past,
That was only because you provided a workbook (as a solution) without posting any code/formulae.
 
Upvote 0
It seems that if I reinstate the error handler, it seems to work???
 
Upvote 0
If it's now working, that's fine.
You're code is jumping around all over the place so much, I simply don't have time to investigate it properly.
 
Upvote 0

Forum statistics

Threads
1,214,819
Messages
6,121,741
Members
449,050
Latest member
excelknuckles

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top