advice & fixing code to clear cells if another is empty

[MKLAQ]

hello
I try making macro by match B2 into sheet2 with column A for sheet1 and brings the values into sheet2 for cells B3:B5. every thing is ok except one thing . if the cell B2 is empty should clear B3:B5 ,but it doesn't clear .
any help to fix it please?

Private Sub Worksheet_Change(ByVal Target As Range)
Dim Fnd As Range, sh1 As Worksheet
Set sh1 = sheet1
  On Error Resume Next
 
   If Target.Address(0, 0) = "B2" And Target.Value <> "" Then
      Set Fnd = sheet1.Range("A:A").Find(Target.Value, , , xlWhole, , , False, , False)
      If Not Fnd Is Nothing Then
      With sheet2
       .Range("B3").Value = Fnd.Offset(, 1).Value
        .Range("B4").Value = Fnd.Offset(, 3).Value
        .Range("B5").Value = Fnd.Offset(, 2).Value
        End With
        Else
        sheet2.Range("B3").Value = ""
        sheet2.Range("B4").Value = ""
        sheet2.Range("B5").Value = ""
        End If
     
   End If
End Sub

thanks

 

[Alex Blakenburg]

As it stands your code will only clear B3:B5 if the Target Value is NOT found in column A.
Since the clear code is in the Else part of If Not Fnd is Nothing. It will not get to this code since it does NOT meet the criteria Target.Value <> ""

You could duplicate the clear lines in an added Else statement for the first If statement so that if Target.Value = "" it performs that else statement.

I think that rather than duplicate, reversing your logic might work for you. ie you only want values to exist if Target.Value is found and <> "".

Private Sub Worksheet_Change(ByVal Target As Range)
Dim Fnd As Range, sh1 As Worksheet
Set sh1 = Sheet1
On Error Resume Next

    If Target.Address(0, 0) = "B2" Then
        'If B2 is changed intialise values to be updated
        sheet2.Range("B3").Value = ""
        sheet2.Range("B4").Value = ""
        sheet2.Range("B5").Value = ""
        
        Set Fnd = Sheet1.Range("A:A").Find(Target.Value, , , xlWhole, , , False, , False)
        'Only update relevant fields if B2 value is found
        If Not Fnd Is Nothing Then
            With sheet2
                .Range("B3").Value = Fnd.Offset(, 1).Value
                .Range("B4").Value = Fnd.Offset(, 3).Value
                .Range("B5").Value = Fnd.Offset(, 2).Value
            End With
        End If
    End If
End Sub

 

[MKLAQ]

actually I hesitated in the beginning to put it in the beginning of the code , I thought to be problem from the whole code something isn't logic .

I thought may be need arranging the procedures to become more logic .

much appreciated

 

[Alex Blakenburg]

No problem. Glad I could help and thanks for the feedback.