Advice for existing code edit please

[ipbr21054]

Morning,

This code works how it should with no problems.

Private Sub Worksheet_SelectionChange(ByVal Target As Range)
    Dim My_Range As Range
    
    Dim LastRow As Long
    
    Set My_Range = Worksheets("COLOR CELLS").Range("A1:Z50")
    
    For Each cell In My_Range
    
    If cell.Value Like "MONDAY" Then
        cell.Interior.ColorIndex = 3
        
    ElseIf cell.Value Like "TUESDAY" Then
        cell.Interior.ColorIndex = 4
        
    ElseIf cell.Value Like "WEDNESDAY" Then
        cell.Interior.ColorIndex = 22
        
    ElseIf cell.Value Like "THURSDAY" Then
        cell.Interior.ColorIndex = 6
        
    ElseIf cell.Value Like "FRIDAY" Then
        cell.Interior.ColorIndex = 7
        
    ElseIf cell.Value Like "SATURDAY" Then
        cell.Interior.ColorIndex = 8
        
    ElseIf cell.Value Like "SUNDAY" Then
        cell.Interior.ColorIndex = 46
        
    Else
        cell.Interior.ColorIndex = xlNone
        
    End If
    
    Next
    
End Sub


However i would like to know how to edit it to not restrict it to the current range shown of which is A1:Z50

I have done the below for it to hopefully work using the xlUp function but im getting deeper into it now not working but popping up error messages

Private Sub Worksheet_SelectionChange(ByVal Target As Range)
    Dim My_Range As Range
    
    Dim LastRow As Long
    
    With Sheets("COLOR CELLS")
    
    If cell.Value Like "MONDAY" Then
        cell.Interior.ColorIndex = 3
        
    ElseIf cell.Value Like "TUESDAY" Then
        cell.Interior.ColorIndex = 4
        
    ElseIf cell.Value Like "WEDNESDAY" Then
        cell.Interior.ColorIndex = 22
        
    ElseIf cell.Value Like "THURSDAY" Then
        cell.Interior.ColorIndex = 6
        
    ElseIf cell.Value Like "FRIDAY" Then
        cell.Interior.ColorIndex = 7
        
    ElseIf cell.Value Like "SATURDAY" Then
        cell.Interior.ColorIndex = 8
        
    ElseIf cell.Value Like "SUNDAY" Then
        cell.Interior.ColorIndex = 46
        
    Else
        cell.Interior.ColorIndex = xlNone
        
    End If
    
    LastRow = .Cells(Rows.Count, "A").End(xlUp).Row + 1
    
    
    End With
    
End Sub

 

[mohadin]

What about

 Set My_Range = Worksheets("COLOR CELLS").CurrentRegion

 

[ipbr21054]

The whole sheet

 

[mohadin]

Maybe

 Set My_Range = Worksheets("COLOR CELLS").Cells()

 

[My Aswer Is This]

Why are you using this:
LastRow = .Cells(Rows.Count, "A").End(xlUp).Row + 1

this appears to mean look for last filled cell in column A

So your saying if any cell on the entire sheet has the value Monday entered you want cell.Interior.ColorIndex = 3

 

[ipbr21054]

Hi,
Post #11 shows not support.
Post #13 locks up the pc

 

[ipbr21054]

I am not sure how to use it so i was trying to work it out,i stopped & put the whole code for you to see.

Yes anywhere on the sheet would change the color etc

 

[My Aswer Is This]

I am not sure how to use it so i was trying to work it out,i stopped & put the whole code for you to see.

Yes anywhere on the sheet would change the color etc

This may be why some codes provided are locking up.
Normally most code like this applies to certain columns or rows.
Having the script look at all 5 billions cells to see if there is a change to a cell where these Days are entered if very tasking.

 

[My Aswer Is This]

Try this:

This script only applies to column 1 to 10
Modify to your needs:

Private Sub Worksheet_Change(ByVal Target As Range)
'Modified  3/16/2021  9:47:47 AM  EDT
If Target.Column > 0 < 11 Then

    Select Case True
        Case (InStr(Target.Value, "MONDAY") > 0): Target.Interior.ColorIndex = 3
        Case (InStr(Target.Value, "TUESDAY") > 0): Target.Interior.ColorIndex = 4
        Case (InStr(Target.Value, "WEDNESDAY") > 0): Target.Interior.ColorIndex = 22
        Case (InStr(Target.Value, "THURSDAY") > 0): Target.Interior.ColorIndex = 6
        Case (InStr(Target.Value, "FRIDAY") > 0): Target.Interior.ColorIndex = 7
        Case (InStr(Target.Value, "SATURDAY") > 0): Target.Interior.ColorIndex = 8
        Case (InStr(Target.Value, "SUNDAY") > 0): Target.Interior.ColorIndex = 46
    
            Case Else
            Target.Interior.Color = xlNone
    
    End Select
End If
End Sub

 

[ipbr21054]

Thanks will take a better look tomorrow