bit of VBA code wrong

[Duritz]

Can someone with more VBA ability than my humble self have a quick peek at this and tell me where I've mucked it up? The error message is below: (this is querying an Access database)

sql_st = "Select * FROM data Where cat_dist = " & dist & " AND where reliability_best_now = " & reliability & " AND where EP_THEN_FINAL_MARK = '" & form & "' AND where cat_fitness = '" & fitness & "'"

and the error message says there's a Syntax error (missing operator)

cat_dist and reliability_best_now are both numbers, the other two are both text

 

[SydneyGeek]

Hi Duritz, it looks like you have too many WHERE operators. Try

sql_st = "Select * FROM data Where cat_dist = " & dist & " AND reliability_best_now = " & reliability & " AND EP_THEN_FINAL_MARK = '" & form & "' AND cat_fitness = '" & fitness & "'"

If that doesn't do the trick, try also using parentheses:

sql_st = "Select * FROM data Where ((cat_dist = " & dist & ") AND (reliability_best_now = " & reliability & ") AND (EP_THEN_FINAL_MARK = '" & form & "') AND (cat_fitness = '" & fitness & "'))"

Denis

 

[Duritz]

Ah yes the Where operators, of course. Removing that has done it. Thanks Denis.

 

[Norie]

Duritz

Just to clarify this is not really a VBA error, it's an error in the syntax of the SQL statement.