ByRef Error

[Ark68]

I am receiving a "ByRef argument type mismatch" error with this line of code calling a procedure.

create_proglist fac, facPgrmTar, timeOpen, timeClose, cdcnt

In my procedure, timeOpen and timeClose (time values) are declared as Date.

Dim timeOpen as date, timeClose as date

Here is the procedure sub being called:

Sub create_proglist(ByRef fac As String, facPgrmTar As Range, timeOpen As Date, timeClose As Date, cdcnt As Double)

Can someone help by suggesting what I need to do to correct this?

 

[Micron]

Put a break point somewhere (after the point where all variables have been assigned values or at the beginning of create_proglist). When the code is still stopped, examine the variables to see what they contain. Can mouse over them or use immediate window of vb editor, as in typing:
?fac and hit enter. Value should appear below. If you get a blank line, it's null or a zls (zero length string). The data type must match what's expected in ByRef parameters but I'm not certain that zls or null would be allowed. If you get a value that looks right, can test its data type with:

?typename(fac) and hit enter. Should return "string"
Note that a number can be string or numeric data, so watch for that. You might be allowing "5" to be passed as a number when you think it is a string.

 

[dmt32]

Hi,
If you don’t want to modify your original data in the calling sub but need to use that data in another sub, then you do not need to pass your arguments ByRef - just pass them ByVal

Sub create_proglist(ByVal fac As String, ByVal facPgrmTar As Range, ByVal timeOpen As Date, ByVal timeClose As Date, ByVal cdcnt As Double)

End Sub

Dave

 

[Ark68]

put a break point somewhere (after the point where all variables have been assigned values or at the beginning of create_proglist). When the code is still stopped, examine the variables to see what they contain. Can mouse over them or use immediate window of vb editor, as in typing:
?fac and hit enter. Value should appear below. If you get a blank line, it's null or a zls (zero length string). The data type must match what's expected in ByRef parameters but I'm not certain that zls or null would be allowed. If you get a value that looks right, can test its data type with:

?typename(fac) and hit enter. Should return "string"
Note that a number can be string or numeric data, so watch for that. You might be allowing "5" to be passed as a number when you think it is a string.

Thanks Micron for your suggestion, but I can't get that far. It breaks with an error when I compile the code (via Debug), or if I step through the procedure row by row. As soon as I press F8 on the 1st line of code for the procedure it errs. I can't get to the point where values are assigned to the variables. (timeOpen etc)

If you don’t want to modify your original data in the calling sub but need to use that data in another sub, then you do not need to pass your arguments ByRef - just pass them ByVal

The value for timeOpen and/or timeClose could change as a result of the code being called. Even when I change from ByRef to ByVal I get the same error.

 

[Ark68]

I found my error. My declaration statement was incomplete.

Dim timeOpen As Date, timeClose As Date

is correct. My original line,

Dim timeOpen ,timeClose As Date

is obviously incorrect.

 

[Micron]

I found my error. My declaration statement was incomplete.

Dim timeOpen As Date, timeClose As Date

is correct. My original line,

Dim timeOpen ,timeClose As Date

is obviously incorrect.

Yeah, I looked for an incorrect declaration but what you said you had looked ok - except it's apparently not what you had.
Because it wasn't specifically typed, you were using a variant, not a string. When using ByRef, data types must be the same AFAIK.