Can't change the format of a Shapes collection

Torquemada

New Member
Joined
Oct 9, 2006
Messages
7
I have 20 shapes on Sheet2 and I want to format them all identically without looping. I put the following in a Workbook:

Public sr As ShapeRange
Private Sub Workbook_Open()
Sheets("Sheet2").Shapes.SelectAll
Set sr = Selection.ShapeRange
sr.Fill.ForeColor.SchemeColor = 12
End Sub

This works fine. Now I go to Sheet2 and try to change all the shape colors to something else with this code in a module:

Public sr As ShapeRange
Sub ChangeColors()
sr.Fill.ForeColor.SchemeColor = 13
End Sub

This won't run. What am I overlooking?
 

Excel Facts

Enter current date or time
Ctrl+: enters current time. Ctrl+; enters current date. Use Ctrl+: Ctrl+; Enter for current date & time.

scifibum

Well-known Member
Joined
Jul 22, 2004
Messages
503
I think the problem is your declaration of the sr variable.

Workbook and worksheet code modules can't contain a truly "Public" variable. Those need to reside in regular code modules. Plus, you should only declare a public variable once - it looks like you've declared it in both the workbook and worksheet modules.

The upshot is that your worksheet code can't access the variable you initialized in the workbook routine. It's accessing the local version of sr which is not initialized.

Try removing the "Public sr as ShapeRange" declaration from both places and put it in a regular code module, and see if that solves the problem.

Hope this helps.
 

Forum statistics

Threads
1,136,700
Messages
5,677,280
Members
419,683
Latest member
MrVBAConfused

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Top