change my 'run on open' macro to 'run before save' macro

oliviar

Board Regular
Joined
Sep 12, 2010
Messages
184
Hi Guys
I have this macro that worked when it was set to run after the sheet opened.

But now I want to change it to run before save or run before print.

I tried to alter it myself but its not working. This is what I have:

Code:
Private Sub Workbook_BeforeSave()
Dim wsheet As Worksheet
For Each wsheet In ActiveWorkbook.Worksheets
Sheets(wsheet.Name).Select
Range("d1").Value = Sheets(1).Range("d1").Value + 1
    Dim r As Range
    Set r = Worksheets("Sheet1").Range("d2")
    With ActiveSheet.PageSetup
        .RightFooter = r
        End With
    
    Next wsheet
End Sub
 

Excel Facts

Which lookup functions find a value equal or greater than the lookup value?
MATCH uses -1 to find larger value (lookup table must be sorted ZA). XLOOKUP uses 1 to find values greater and does not need to be sorted.
oliviar - could not get your macro to run. I use:

Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)

which is located in ThisWorkbook

HTH!
 
Upvote 0
Hi Guys
I have this macro that worked when it was set to run after the sheet opened.

But now I want to change it to run before save or run before print.

I tried to alter it myself but its not working. This is what I have:

Code:
Private Sub Workbook_BeforeSave()
Dim wsheet As Worksheet
For Each wsheet In ActiveWorkbook.Worksheets
Sheets(wsheet.Name).Select
Range("d1").Value = Sheets(1).Range("d1").Value + 1
    Dim r As Range
    Set r = Worksheets("Sheet1").Range("d2")
    With ActiveSheet.PageSetup
        .RightFooter = r
        End With
    
    Next wsheet
End Sub

It works in the BeforeClose event. Don't know if that helps?

Code:
Private Sub Workbook_BeforeClose(Cancel As Boolean)
Dim wsheet As Worksheet
For Each wsheet In ActiveWorkbook.Worksheets
Sheets(wsheet.Name).Select
Range("d1").Value = Sheets(1).Range("d1").Value + 1
    Dim r As Range
    Set r = Worksheets("Sheet1").Range("d2")
    With ActiveSheet.PageSetup
        .RightFooter = r
        End With
    
    Next wsheet

End Sub
 
Upvote 0

Forum statistics

Threads
1,213,538
Messages
6,114,218
Members
448,554
Latest member
Gleisner2

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top