change my 'run on open' macro to 'run before save' macro

oliviar

Board Regular
Joined
Sep 12, 2010
Messages
184
Hi Guys
I have this macro that worked when it was set to run after the sheet opened.

But now I want to change it to run before save or run before print.

I tried to alter it myself but its not working. This is what I have:

Code:
Private Sub Workbook_BeforeSave()
Dim wsheet As Worksheet
For Each wsheet In ActiveWorkbook.Worksheets
Sheets(wsheet.Name).Select
Range("d1").Value = Sheets(1).Range("d1").Value + 1
    Dim r As Range
    Set r = Worksheets("Sheet1").Range("d2")
    With ActiveSheet.PageSetup
        .RightFooter = r
        End With
    
    Next wsheet
End Sub
 

Mr_Roscoe

Board Regular
Joined
Mar 28, 2006
Messages
200
oliviar - could not get your macro to run. I use:

Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)

which is located in ThisWorkbook

HTH!
 

John Davis

Well-known Member
Joined
Sep 11, 2007
Messages
3,457
Hi Guys
I have this macro that worked when it was set to run after the sheet opened.

But now I want to change it to run before save or run before print.

I tried to alter it myself but its not working. This is what I have:

Code:
Private Sub Workbook_BeforeSave()
Dim wsheet As Worksheet
For Each wsheet In ActiveWorkbook.Worksheets
Sheets(wsheet.Name).Select
Range("d1").Value = Sheets(1).Range("d1").Value + 1
    Dim r As Range
    Set r = Worksheets("Sheet1").Range("d2")
    With ActiveSheet.PageSetup
        .RightFooter = r
        End With
    
    Next wsheet
End Sub
It works in the BeforeClose event. Don't know if that helps?

Code:
Private Sub Workbook_BeforeClose(Cancel As Boolean)
Dim wsheet As Worksheet
For Each wsheet In ActiveWorkbook.Worksheets
Sheets(wsheet.Name).Select
Range("d1").Value = Sheets(1).Range("d1").Value + 1
    Dim r As Range
    Set r = Worksheets("Sheet1").Range("d2")
    With ActiveSheet.PageSetup
        .RightFooter = r
        End With
    
    Next wsheet

End Sub
 

Forum statistics

Threads
1,081,747
Messages
5,361,038
Members
400,610
Latest member
ebey

Some videos you may like

This Week's Hot Topics

  • populate from drop list with multiple tables
    Hi All, i have a drop list that displays data, what i want is when i select one of those from the list to populate text from different tables on...
  • Find list of words from sheet2 in sheet1 before a comma and extract text vba
    Hi Friends, Trying to find the solution on my task. But did not find suitable one to the need. Here is my query and sample file with details...
  • Dynamic Formula entry - VBA code sought
    Hello, really hope one of you experts can help with this - i've spent hours on this and getting no-where. .I have a set of data (more rows than...
  • Listbox Header
    Have a named range called "AccidentsHeader" Within my code I have: [CODE]Private Sub CommandButton1_Click() ListBox1.RowSource =...
  • Complex Heat Map using conditional formatting
    Good day excel world. I have a concern. Below link have a list of countries that carries each country unique data. [URL...
  • Conditional formatting
    Hi good morning, hope you can help me please, I have cells P4:P54 and if this cell is equal to 1 then i want row O to say "Fully Utilised" and to...
Top