Checking values in one column

[Konrado]

Hi, I want to write a code which checks values in one column. If they're equal, they have yellow color. Unfortunately, my code doesn't work. If you could help me, I will be very happy. My code below.


Sub Compare()
Dim sh As Range
Dim i, j As Long
For Each sh In Range("A1:A17")
For i = 1 To 17
For j = 1 To 17
If sh(i, "A") = sh(j, "A") Then
sh(i, "A").Interior.Color = vbYellow
sh(j, "A").Interior.Color = vbYellow
End If
Next j
Next i
Next sh
End Sub

 

[Special-K99]

Am No VBA expert but does this work?

Sub Compare()
Dim i, j As Long
For i = 1 To 16
For j = i+1 To 17
If Cells(i, 1) = Cells(j, 1) Then
Cells(i, 1).Interior.Color = vbYellow
Cells(j, 1).Interior.Color = vbYellow
End If
Next j
Next i
End Sub

Note removal of sh loop
There's prob a better way to do it