closing excel without saving - not working properly

[smakatura]

I have two documents. sourcedocument and fulldatafilename. I pull data from the fulldatafilename, paste into sourcedocument and then close source document.

I can open fulldatafilename and work with it and even switch between the sourcedocument. but I can not seem to close the fulldatafilename. and I have not 'undefined' fulledatafilename.

I am using similar coding to below. (I have simplified it to the basic code for easier reading). assume I am runnig the macro from sourcedocument

    Dim fulldatafilename As String
    Dim sourcedocument As String
 
    fulldatafilename = "data file 089-2.xlsx"
    sourcedocument = "JOBS Weekly Template.xlsm"
 
    Workbooks.Open Filename:=fulldatafilename     'this works
          '******code for copying data from fulldata filename here
    Windows(sourcedocument).Activate     'this works
          '******code for pasting data from fulldata filename here
    ActiveWorkbook.Save    'this properly saves the source document
 
    Workbooks(fulldatafilename).Close False     ' this is the part that is not working.

not sure why not working bc Workbooks(fulldatafilename).Close False or similar code works in other macros.

 

[andiemac]

If you do not want or need to save "fulldatafilename" you could try adding one line before your close action:

Workbooks(fulldatafilename).saved

This tells Excel that it's already been saved and no save before close check is required.

 

[smakatura]

that is correct, I do not wish to save the changes made to fulldatafilename...but willl the extra saved statement allow it save...the macro gets stuck on the code and will not even ask me if I want to save.

 

[andiemac]

I noticed something else when looking at this again. Your code says
workbooks(...).close false

Try getting rid of that. And if that doesnt work switching it to true.

 

[smakatura]

if I change the false to true, it will save the changes made. I don't want to save my changes.

I tried

Workbooks(fulldatafilename).saved

and it did not work. it did not like the command

 

[smakatura]

I figured out why it was not working. fulldatafilename included the c: portions of the file....so my full definitions were(which I did not include originally and therefore made the question incomplete)

    Dim rptdate As String
    Dim datafilename As String
    Dim datafilelocation As String
    Dim fulldatafilename As String
   
       
    datafilelocation = "C:\Users\smakatura\Documents\call report\Call Reports\JOBS Center Call Log Master\"
    datafilename = "JOBS Center Call Log Master "
    rptdate = "09-26-11"
    fulldatafilename = datafilelocation & datafilename & rptdate & ".xlsx"

once I changed the command from

Workbooks(fulldatafilename).Close False

to

Workbooks(datafilename & rptdate & ".xlsx").Close SaveChanges:=False

it worked. trouble was I was trying to close with the path also ...not just the open file name.

thank you for everyones help