Code for pictures on a form

[mbono1]

Hi all,

I battled with something very very basic. I am trying to change a picture, when a certain field matches a certain criteria. But i can't seem to get it to update.

I have the following code which I have simplified.

If [JV].Value = "One" Then

[OLEUnbound10].Visible = True
[OLEUnbound118].Visible = False
[OLEUnbound11].Visible = False

If [JV].Value = "Two" Then

[OLEUnbound10].Visible = False
[OLEUnbound118].Visible = True
[OLEUnbound11].Visible = False

If [JV].Value = "Three" Then

[OLEUnbound10].Visible = False
[OLEUnbound118].Visible = False
[OLEUnbound11].Visible = True

End If
End If
End If

I want these pictures to update when the form is loaded, as well as when the field is changed.

Any idea's?

Anybodys help would be appreciated.

thanks

mbono1

 

[Andrew Fergus]

Hi

It looks like you have nested your if statements. Rather than use 3 'if' statements and 3 'end if' statements, change the 2nd and 3rd 'if' statements to 'elseif' and delete 2 of the 3 'end if' statements.

Andrew

 

[SydneyGeek]

If you have several sets of options, a Select Case statement is easier to maintain. I would create a separate routine on the form's code module, then reference that in the form's Current event and the field's AfeterUpdate event:

Private Sub ShowImages()
    Select Case [JV].Value
    Case "One"
        [OLEUnbound10].Visible = True
        [OLEUnbound118].Visible = False
        [OLEUnbound11].Visible = False
    Case "Two"
        [OLEUnbound10].Visible = False
        [OLEUnbound118].Visible = True
        [OLEUnbound11].Visible = False
    Case "Three"
        [OLEUnbound10].Visible = False
        [OLEUnbound118].Visible = False
        [OLEUnbound11].Visible = True
    End Select
End Sub

Private Sub Form_Current()
    ShowImages
End Sub

Private Sub JV_AfterUpdate()
    ShowImages
End Sub

To make sure that the events fire correctly, go to the Properties for the form, select the Events tab, and double-click the Current line so you see Event Procedure. Do the same for the After Update event of the JV control.

Denis