Code help change cell color...Not working

JaredMcCullough

Well-known Member
Joined
Aug 1, 2011
Messages
516
Its been quite a while since I have used vba/macros. Thought this was an easy one but I guess not. The codes intent is to just change cell color based on 1 of 2 variables. I keep getting an error stating no "for" statement? Wish I stayed more involved so I wouldnt feel so stupid.



Code:
Private Sub Worksheet_Change(ByVal Target As Range)
Dim cell As Range
 
For Each cell In Range("O5:U5000")
 
    If cell.Value = "P" Then
     cell.Interior.Color = vbGreen
 
    If cell.Value = "F" Then
    cell.Interior.Color = vbRed
 
End If
Next cell
End Sub
 

Excel Facts

Back into an answer in Excel
Use Data, What-If Analysis, Goal Seek to find the correct input cell value to reach a desired result

Comfy

Well-known Member
Joined
Dec 21, 2009
Messages
3,386
You're missing an End If

Code:
Dim cell As Range
 
For Each cell In Range("O5:U5000")
 
    If cell.Value = "P" Then
     cell.Interior.Color = vbGreen
 
    If cell.Value = "F" Then
    cell.Interior.Color = vbRed
 
End If
End If
Next cell
 

Norie

Well-known Member
Joined
Apr 28, 2004
Messages
76,344
Office Version
  1. 365
Platform
  1. Windows
Try this.
Code:
Private Sub Worksheet_Change(ByVal Target As Range)
Dim cell As Range
 
    For Each cell In Range("O5:U5000")
 
        If cell.Value = "P" Then
            cell.Interior.Color = vbGreen
        End If

        If cell.Value = "F" Then
            cell.Interior.Color = vbRed
        End If

    Next cell

End Sub
 
Master Excel Bundle

Excel contains over 450 functions, with more added every year. That’s a huge number, so where should you start? Right here with this bundle.

Forum statistics

Threads
1,164,015
Messages
5,834,939
Members
430,327
Latest member
Mr_Himalayan778

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Top