Code help change cell color...Not working

JaredMcCullough

Well-known Member
Joined
Aug 1, 2011
Messages
516
Its been quite a while since I have used vba/macros. Thought this was an easy one but I guess not. The codes intent is to just change cell color based on 1 of 2 variables. I keep getting an error stating no "for" statement? Wish I stayed more involved so I wouldnt feel so stupid.



Code:
Private Sub Worksheet_Change(ByVal Target As Range)
Dim cell As Range
 
For Each cell In Range("O5:U5000")
 
    If cell.Value = "P" Then
     cell.Interior.Color = vbGreen
 
    If cell.Value = "F" Then
    cell.Interior.Color = vbRed
 
End If
Next cell
End Sub
 

Excel Facts

Ambidextrous Undo
Undo last command with Ctrl+Z or Alt+Backspace. If you use the Undo icon in the QAT, open the drop-down arrow to undo up to 100 steps.
You're missing an End If

Code:
Dim cell As Range
 
For Each cell In Range("O5:U5000")
 
    If cell.Value = "P" Then
     cell.Interior.Color = vbGreen
 
    If cell.Value = "F" Then
    cell.Interior.Color = vbRed
 
End If
End If
Next cell
 
Upvote 0
Try this.
Code:
Private Sub Worksheet_Change(ByVal Target As Range)
Dim cell As Range
 
    For Each cell In Range("O5:U5000")
 
        If cell.Value = "P" Then
            cell.Interior.Color = vbGreen
        End If

        If cell.Value = "F" Then
            cell.Interior.Color = vbRed
        End If

    Next cell

End Sub
 
Upvote 0

Forum statistics

Threads
1,214,826
Messages
6,121,797
Members
449,048
Latest member
greyangel23

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top