Code in BeforeClose is executing but having no effect


Active Member
Jun 22, 2005
I have the following code in an Excel 2010 workbook:

Private Sub Workbook_BeforeClose(Cancel As Boolean)

    Application.EnableEvents = True

    Dim FileName As String
    FileName = ActiveWorkbook.Name

    If FileName = "False" Then Exit Sub
    If FileName <> "Shipping Manifest SaveAS Update.xlsm" Then
        Application.DisplayAlerts = False
        ActiveWorkbook.SaveAs FileName:=FileName, FileFormat:=xlOpenXMLWorkbookMacroEnabled, WriteResPassword:="abc123", ReadOnlyRecommended:=True
        Application.DisplayAlerts = True
    End If
End Sub
The code executes - I checked by inserting a breakpoint and stepping through it. But the password protection to open the file as Read Only unless the password is entered is not being applied - the file just opens as normal. What am I doing wrong?


New Member
Dec 30, 2016
Your code worked fine for me. Just in case, this code should be into ThisWorkbook, not in module.

Forum statistics

Latest member

Some videos you may like

This Week's Hot Topics

  • VBA code giving errors and stopping Excel
    Hello Experts, I have this code being used to loop through files in a file path, and copy specific data to another sheet. It is giving me several...
  • Disable MsgBox message
    Morning, I have a userform where if i leave a ComboBox empty i see a MsgBox warning me that i must enter an invoice number. It is this MsgBox i...
  • Macro Recorder into VBA, Copy Paste Data Filled Cells
    Hi Everyone, I have a macro recorder file that takes a selection of data, copies, then pastes into a new sheet on ("A2:B2") The issue is my...
  • Number format changes while pasting into a cell
    Hi, I am trying to paste a number 180204524303 from an email to an excel cell, however, whenever i try to do so , the the paste value appears as...
  • Collating data
    Hello all. Could someone please help. I am trying to pull all column data from multiple sheets (24 I total so far) into 1 master sheet without...
  • Sum Multiple Columns Based on Multiple Criteria
    I am trying to consolidate data by summing columns G through M based on material, plant, vendor, and fiscal year being identical. The period does...