Code Optimisation

[JackDanIce]

Hi,

Inherited some code that I'm working through to optimise and update e.g.

Sheet1.Range("A1:A200").Copy
Sheet2.Range("B1:B200").Pastespecial Paste:=xlPasteValues
Application.CutCopyMode = False

Can be replaced by:

Sheet2.Range("B1:B200").Value = Sheet1.Range("A1:A200").Value

However, what I'd like to know is how to apply this, when you don't know the last row number and the starting row number is different in each sheet e.g.

Dim i as Long
i = Sheet1.Range("A" & Rows.Count).End(xlUp).Row
Sheet2.Range("K1").Value = Sheet1.Range("A30:B" & i).Value

With this example, Sheet2.K1 is given the value of Sheet1.A1 i.e. not what I want

This works but it's not quite what I want:

Dim i as Long
i = Sheet1.Range("A" & Rows.Count).End(xlUp).Row
Sheet2.Range("K1:L" & i - 29).Value = Sheet1.Range("A30:B" & i).Value

I have a feeling .Resize may be the answer and ashamed to say, I've still not got around to understanding exactly how this property works.

Any comments, suggestions?

Thanks,
Jack

 

[RoryA]

Given that you are hardcoding a start range on both sides, why is the i - 29 version not OK?

You could use something like:

Dim varData
varData = Sheet1.Range("A30:B" & i).Value2
Sheet2.Range("K1").Resize(ubound(vardata, 1), Ubound(vardata, 2)).Value2 = vardata

 

[JackDanIce]

Thanks Rory, reason it's not ok is because the data may not always start at row 30 and I was hoping to avoid going through the code and hardcoding the relative references everywhere

I think your suggestion is closer to what I had in mind but can you explain please what ".Value2" is, why vardata is a variant variable and say not a range variable and the use of Ubound?

PS Nice signature, hadn't noticed it before!

 

[RoryA]

varData is a variant so that you can just dump the values into it and get an array. Value2 is like Value except that it uses Doubles instead of Date (and therefore usually safer for us non-US personnel) or Currency data, and is a bit faster. Because you have an array, you need Ubound to work out how many rows/columns it has in order to resize the output range.

 

[JackDanIce]

Thats great and gives me some options to work with. Thank you