Combining Do Loops with other Macros statements

damien120

New Member
Joined
Feb 13, 2019
Messages
8
Hello all,

I am looking to make 1000+ reports based on a template. I have other sheets referencing the target city to update the data they report on. I have a master macro that calls on three other macros to format accordingly and save as "Location Report- Austin 1".

After creating the Austin report, I am looking to make one based out of the Dallas location. Thus I change the Target City to that all the other sheets will automatically update and then run the three macros (format and save file). My question is, how can I loop my macro so that it works its way down the 1,000+ cities. I am wondering if I can combine a Do Until statement and embed the other three macros within it.



City#Target#
Austin
1Austin1
Dallas2
Houston3
Chicago4
Miami5
Phoenix6
......
......

<tbody>
</tbody>


Thank you in advance and will greatly appreciate any guidance.
 

Excel Facts

What does custom number format of ;;; mean?
Three semi-colons will hide the value in the cell. Although most people use white font instead.
This macro assumes the city names are in column A.
Code:
Sub Test()
    Application.ScreenUpdating = False
    Dim city As Range
    For Each city In Range("A2", Range("A" & Rows.Count).End(xlUp))
        'your code here
    Next city
    Application.ScreenUpdating = True
End Sub
 
Upvote 0
Thank you for mumps for the answer!

After the new city populates, I am trying to save the report. Following a naming convention so that the report is saved as "Austin 1". The code down below is what I added where you advised.

I am now getting a "Run-time error '1004'
Cannot access 'Austin 1.xlsm'

ActiveWorkbook.SaveAs Filename:="C:[File Path] & Range("C2").Text & Chr(32) & Range("D2").Text & ".xlsm", FileFormat:= _
xlOpenXMLWorkbookMacroEnabled, Password:=vbNullString, WriteResPassword:=vbNullString, _
ReadOnlyRecommended:=False, CreateBackup:=False
 
Upvote 0
It is difficult to suggest a solution without seeing your macros and how your workbook is organized. Perhaps you could upload a copy of your file to a free site such as www.box.com or www.dropbox.com. Once you do that, mark it for 'Sharing' and you will be given a link to the file that you can post here. Include a detailed explanation of what you would like to do using a few examples from your data and referring to specific cells, rows, columns and worksheets. If the workbook contains confidential information, you could replace it with generic data.
 
Upvote 0
Could you upload a version of your file that includes all the macros you are currently using?
 
Upvote 0

Forum statistics

Threads
1,214,606
Messages
6,120,492
Members
448,967
Latest member
visheshkotha

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top