Control UserForm through procedure iin module

[Stevenn]

I have a module with a procedure called Upload() and a UserForm where the user should insert both username and password and click the command button.

I want to control the UserForm through the procedure Upload() instead of using cmdUpload_Click and such. Something like

Public Sub Upload()
    With frmUpload
        .txtUsername = VBA.Environ("Username")
        .txtPassword.SetFocus
        .Show
    End With
End Sub

but how can I check if the user had clicked the command button and eventually make a progress bar in the UserForm? I hope my problem is clearly explained

 

[Kyle123]

You'd use Custom Events and a class, however I'm not really sure why you'd want to do this.

Can you give us a little background as to why you need to do this?

 

[Stevenn]

You'd use Custom Events and a class, however I'm not really sure why you'd want to do this.

Can you give us a little background as to why you need to do this?

I just want to combine the module which activates the UserForm and the module which does the upload-thing. I thought there were some kind of functions which could do it for me (like Load or something), but if it's more difficult than doing the upload-thing in the UserForm-procedures, then I will continue doing it that way. Would it be preferable to do the upload-thing in the procedure cmdUpload_Click()?

 

[Kyle123]

You could do something like the below but it's really horrible design. If you (or someone else) comes back to it in 12 months time, you would have to hunt to follow the code which would be a massive pain. Try to keep your code as close to the things that trigger it as possible, it makes maintenance easier and much more logical.

In your Form:

Private Sub cmdUpload_Click()
btnClicked
End Sub

In your module

Public Sub btnClicked()
'Do Something....
End Sub

It's not a good approach though - coming back to this if it were a large project would be problematic as you would have to find the btnClicked sub. Just put the upload code in the upload button, it's logical and easy to track

 

[Norie]

What is the purpose of the userform and what do you want to 'control' on it?

Why not just call the upload code when a command button is clicked?

Private Sub CommandButton1_ Click()
    Call UploadSub
End Sub