Copying Between Workbooks VBA

[Gregorys05]

Hi Guys,
I have the below code that i recorded but is there a better way of copying and pasting data from one workbook to another.

Windows("India Errors Report.xls").Activate
    Range("D4").Select
    Range(Selection, Selection.End(xlDown)).Select
    Application.CutCopyMode = False
    Selection.Copy
    Windows("QAChecker.xls").Activate
    Sheets("QAChecker").Select
    Range("C2").Select
    Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
        :=False, Transpose:=False
    Windows("India Errors Report.xls").Activate
    Range("F4").Select
    Range(Selection, Selection.End(xlDown)).Select
    Application.CutCopyMode = False
    Selection.Copy
    Windows("QAChecker.xls").Activate
    Sheets("Error Type").Select
    Range("C2").Select
    Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
        :=False, Transpose:=False
    Windows("India Errors Report.xls").Activate
    Range("G4").Select
    Range(Selection, Selection.End(xlDown)).Select
    Application.CutCopyMode = False
    Selection.Copy
    Windows("QAChecker.xls").Activate
    Sheets("Processor").Select
    Range("C2").Select
    Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
        :=False, Transpose:=False
    Range("F20").Select

Thanks

 

[MrKowz]

There is a lot that can be cleaned up in that. First thing to clean up is getting rid of all those select/selection statements.

What is the name of the sheet you are pulling data from in the "India Errors Report.xls" file?

 

[Gregorys05]

Its Called Error

 

[MrKowz]

Try the following:

Dim wb1 As Workbook, _
    ws1 As Worksheet, _
    wb2 As Workbook, _
    LR  As Long
    
Set wb1 = Workbooks("India Errors Report.xls")
Set ws1 = wb1.Sheets("Error")

Set wb2 = Workbooks("QAChecker.xls")

LR = ws1.Range("D" & Rows.Count).End(xlUp).Row

ws1.Range("D4:D" & LR).Copy
wb2.Sheets("QAChecker").Range("C2").PasteSpecial Paste:=xlPasteValues
ws1.Range("F4:F" & LR).Copy
wb2.Sheets("Error Type").Range("C2").PasteSpecial Paste:=xlPasteValues
ws1.Range("G4:G" & LR).Copy
wb2.Sheets("Processor").Range("C2").PasteSpecial Paste:=xlPasteValues