Copying Of Data Not Working

[John Davis]

Hello All:

I have the code below it's not working. Can anyone provide any input why this is not doing what it is supposed to do?


Workbooks.Open Filename:="D:\Common\data\IBMmain\OCEAN-BP.xls"
Rows("1:1").Delete
Workbooks.Open Filename:="D:\Common\data\IBMmain\OCEAN-HEADER.xls"
Rows("1:5").Copy
Windows("OCEAN-BP.xls").Activate
Rows("1:5").Select
ActiveSheet.Paste
ActiveWorkbook.Close

 

[Norie]

Something like this perhaps?

Dim wbDst As Workbook
Dim wbSrc As Workbook
Set wbDst = Workbooks.Open(Filename:="D:\Common\data\IBMmain\OCEAN-BP.xls")
wbDst.ActiveSheet.Rows("1:1").Delete
Set wbSrc = Workbooks.Open(Filename:="D:\Common\data\IBMmain\OCEAN-HEADER.xls")
wbDst.ActiveSheet.Rows("1:5").Copy wbDst.ActiveSheet.Range("A1")
wbSrc.Close

 

[John Davis]

Something like this perhaps?

Dim wbDst As Workbook
Dim wbSrc As Workbook
Set wbDst = Workbooks.Open(Filename:="D:\Common\data\IBMmain\OCEAN-BP.xls")
wbDst.ActiveSheet.Rows("1:1").Delete
Set wbSrc = Workbooks.Open(Filename:="D:\Common\data\IBMmain\OCEAN-HEADER.xls")
wbDst.ActiveSheet.Rows("1:5").Copy wbDst.ActiveSheet.Range("A1")
wbSrc.Close

Norie:

For some reason this code is not working. I'm trying to get the first 5 row of OCEAN-HEADER to COPY to OCEAN-BP??

 

[Norie]

John

That was untested 'air' code based on what you posted.

In what way does it not work?

Does it error?

Does it do nothing?

One problem I see is that there are no worksheet references in the original code, that's why I added ActiveSheet.

 

[John Davis]

John

That was untested 'air' code based on what you posted.

In what way does it not work?

Does it error?

Does it do nothing?

One problem I see is that there are no worksheet references in the original code, that's why I added ActiveSheet.

It doesn't error. It just doesn't copy the data into OCEAN-BP.

 

[Norie]

My bad I think.

As I said untested.

wbSrc.ActiveSheet.Rows("1:5").Copy wbDst.ActiveSheet.Range("A1")

And the use of Activate/Select in the original code actually makes it hard to follow what's going on.