Correct IF statement

[Floki]

I'm having some problems with this IF paragraph -- I could break it down, but that's not efficient. What the best way to code this - it's in a UDF that I'm trying to work on.

If Cond = "BCAT" Or Cond = "BA/M" And QF >= 0 And QF < 3 Then
Per = 0.4
ElseIf Cond = "BCAT" Or Cond = "BA/M" And QF > 4 And QF < 10 Then
Per = 0.35
ElseIf Cond = "BCAT" Or Cond = "BA/M" And QF > 9 And QF < 15 Then
Per = 0.3
ElseIf Cond = "BCAT" Or Cond = "BA/M" And QF > 14 And QF < 20 Then
Per = 0.25
ElseIf Cond = "BCAT" Or Cond = "BA/M" And QF > 19 And QF < 26 Then
Per = 0.2
ElseIf Cond = "BCAT" Or Cond = "BA/M" And QF > 25 Then
Per = 0.15
End If

Floki

 

[Jonmo1]

You probably need to be more inclusive with your ranges..
If Cond = "BCAT" Or Cond = "BA/M" And QF >= 0 And QF < 3 Then
ElseIf Cond = "BCAT" Or Cond = "BA/M" And QF > 4 And QF < 10 Then

What if QF = exactly 3 or 4 ? Both of those statements would be false.

You probably want something like
If Cond = "BCAT" Or Cond = "BA/M" And QF >= 0 And QF <= 3 Then
ElseIf Cond = "BCAT" Or Cond = "BA/M" And QF >= 4 And QF <= 10 Then


Also, you may need (parens) to clarify which parts belong to which or/and..
Do you want
If (Cond = "BCAT" Or Cond = "BA/M") And (QF >= 0 And QF < 3) Then
or
If Cond = "BCAT" Or (Cond = "BA/M" And QF >= 0 And QF < 3) Then

 

[AlphaFrog]

You could 1st test for If Cond = "BCAT" Or Cond = "BA/M" Then

    [COLOR=darkblue]If[/COLOR] Cond = "BCAT" [COLOR=darkblue]Or[/COLOR] Cond = "BA/M" [COLOR=darkblue]Then[/COLOR]
        [COLOR=darkblue]If[/COLOR] QF >= 0 And QF < 3 [COLOR=darkblue]Then[/COLOR]
            Per = 0.4
        [COLOR=darkblue]ElseIf[/COLOR] QF > 4 And QF < 10 [COLOR=darkblue]Then[/COLOR]
            Per = 0.35
        [COLOR=darkblue]ElseIf[/COLOR] QF > 9 And QF < 15 [COLOR=darkblue]Then[/COLOR]
            Per = 0.3
        [COLOR=darkblue]ElseIf[/COLOR] QF > 14 And QF < 20 [COLOR=darkblue]Then[/COLOR]
            Per = 0.25
        [COLOR=darkblue]ElseIf[/COLOR] QF > 19 And QF < 26 [COLOR=darkblue]Then[/COLOR]
            Per = 0.2
        [COLOR=darkblue]ElseIf[/COLOR] QF > 25 [COLOR=darkblue]Then[/COLOR]
            Per = 0.15
        [COLOR=darkblue]End[/COLOR] [COLOR=darkblue]If[/COLOR]
    [COLOR=darkblue]End[/COLOR] [COLOR=darkblue]If[/COLOR]

 

[Floki]

AlphaFrog,

Thanks for your help -- it worked perfectly. Just finished up the rest of the coding and did testing for all the different conditions -- work great now due to your help.

Floki