# Count unique values based off criteria -- Existing code works too long to run

#### ItalianPlatinum

##### Active Member
Hello - I have the below VBA embedded into my long process. it works as designed problem is. my VBA in total takes 18mins; but this one section in the code itself takes 15min of it. Is there any other way or improvement within the code someone could see to speed it up?

VBA Code:
``````Sub UniqueCount()
Dim d As Object
Dim a As Variant, Ky As Variant
Dim lastrw As Long, i As Long
Dim s As String
Dim wsDest As Worksheet

Const ResultWorkbook As String = "COMPARSION.xlsm"  '<- Edit to suit
Const ResultWorksheet As String = "main"   '<- Edit to suit
Const ResultTopLeft As String = "J5"          '<- Where you want the results
Const CritColValCol As String = "3 5"         '<- Criteria column & Values column in that order. Edit to suit.

With Workbooks("_ALL.xlsm").Sheets("Post Rel")
lastrw = .Cells(.rows.count, CLng(Split(CritColValCol)(0))).End(xlUp).Row
a = Application.Index(.Cells, Evaluate("row(2:" & lastrw & ")"), Split(CritColValCol))
Set d = CreateObject("Scripting.Dictionary")
For i = 1 To UBound(a)
s = "|" & a(i, 2) & "|"
If InStr(1, d(a(i, 1)), s, 1) = 0 Then d(a(i, 1)) = d(a(i, 1)) & s
Next i
ReDim a(1 To d.count, 1 To 2)
i = 0
For Each Ky In d.Keys()
i = i + 1
a(i, 1) = Ky: a(i, 2) = UBound(Split(d(Ky), "||")) + 1
Next Ky

End With
With Workbooks(ResultWorkbook).Sheets(ResultWorksheet).Range(ResultTopLeft)
.Resize(, 2).Value = Array("Vs", "Trans")
.Offset(1).Resize(d.count, 2).Value = a
End With
End Sub``````

#### Peter_SSs

##### MrExcel MVP, Moderator
Actually, the code did not produce the same results for me as my earlier code ... but if the OP is happy .. so am I.

### Excel Facts

What is the fastest way to copy a formula?
If A2:A50000 contain data. Enter a formula in B2. Select B2. Double-click the Fill Handle and Excel will shoot the formula down to B50000.

#### ZVI

##### MrExcel MVP
Not sure, but difference can be in the added `d.CompareMode = 1` to exclude case sensetivety.
For regret there is no posted part of the correct data with the expected result to compare.

Last edited:

Replies
0
Views
101
Replies
1
Views
284
Replies
18
Views
330
Replies
1
Views
87
Replies
0
Views
81

1,132,781
Messages
5,655,253
Members
418,183
Latest member
skaufman

### We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.

### Which adblocker are you using?

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

### Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

### Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back