Deleting all rows in sheet that do not match specified date range using VBA

[aldousjg]

Hi all,

I am creating a macro to delete all rows from a sheet that do not meet a specified date range.

The sheet to delete from is named "PreparedData". The start date and end date of the range are specified in cells G5 and I5 respectively in sheet "Macro". Within the "PreparedData" sheet, the dates are in column BP.

This is what I have so far:

Dim lRow As Long
Dim iCntr As Long

lRow = Sheets("PreparedData").UsedRange.Rows.Count

For iCntr = lRow To 1 Step -1
If Cells(iCntr, BP) < Sheets("Macro").Range("G5").Value Then
Rows(iCntr).Delete
Else
If Cells(iCntr, BP) > Sheets("Macro").Range("G5").Value Then
Rows(iCntr).Delete
End If

I know that this loop is wrong, would anyone be able to help to get this to work?

Thankyou

 

[mart37]

For iCntr = lRow To 1 Step -1
   If Cells(iCntr, "BP") < Sheets("Macro").Range("G5").Value Or Cells(iCntr, "BP") > Sheets("Macro").Range("I5").Value Then Rows(iCntr).Delete
Next

 

[Joe4]

Welcome to the Board!

Two things:
1. If BP is your column reference, it need to be enclosed in double-quotes, i.e. "BP"
2. Your second IF should be referencing I5, not G5 (otherwise, you are deleting ALL rows, except for those exactly equal to G5).

You can simplyify it all down to this:

Sub MyDeleteRows()

    Dim lRow As Long
    Dim iCntr As Long

    Application.ScreenUpdating = False

    lRow = Sheets("PreparedData").UsedRange.Rows.Count

    For iCntr = lRow To 1 Step -1
        If (Cells(iCntr, "BP") < Sheets("Macro").Range("G5").Value) Or (Cells(iCntr, "BP") > Sheets("Macro").Range("I5").Value) Then
            Rows(iCntr).Delete
        End If
    Next iCntr
        
    Application.ScreenUpdating = True

End Sub

 

[aldousjg]

Thanks both, these worked perfectly!

 

[Joe4]

You are welcome.

Glad we could help!