deleting rows with specific criteria

jbmahoney

Board Regular
Joined
Jul 20, 2005
Messages
93
I am trying to delete rows in a spreadsheet which have 'other - rubbish bin' in column S. Whenever I use the following scrpit, it deletes the heading row (row A). How can I get round this and is there a better way to get rid of all rows with this criteria in?

Sub breaktest()
'
' breaktest Macro
' Macro recorded 12/10/2006 by John Royle

Dim lastrow As Long

Sheets("BREAKS>$1m").Select
Selection.AutoFilter field:=19, Criteria1:="other - rubbish bin"
Selection.SpecialCells(xlCellTypeVisible).Select
Selection.Delete Shift:=xlUp
Selection.AutoFilter field:=19
Rows("2:21575").Select

End Sub
 

Excel Facts

Format cells as currency
Select range and press Ctrl+Shift+4 to format cells as currency. (Shift 4 is the $ sign).

pgc01

MrExcel MVP
Joined
Apr 25, 2006
Messages
19,884
Hi John

One possibility is to filter atarting in row 2.

Please try:

Code:
Sub breaktest()
Dim rRng As Range

With Sheets("BREAKS>$1m")
    Set rRng = .Range("S2", .Range("S" & .Rows.Count).End(xlUp))
    rRng.AutoFilter field:=1, Criteria1:="other - rubbish bin"
    rRng.SpecialCells(xlCellTypeVisible).Delete Shift:=xlUp
    .AutoFilterMode = False
End With
End Sub

Hope this helps
PGC
 

sykes

Well-known Member
Joined
May 1, 2002
Messages
1,813
Office Version
  1. 365
Platform
  1. Windows
Hello my 'ansom

This should do what you wish:
Code:
Sub breaktest()
Dim i As Integer
i = Range("S65536").End(xlUp).Row
For Each c In sheets("BREAKS>$1m").Range("S2:S" & i)
    If c.Value = "other - rubbish bin" Then
        c.EntireRow.Delete
    End If
Next
End Sub

All the best

d'rectly.....
 

pgc01

MrExcel MVP
Joined
Apr 25, 2006
Messages
19,884
Hi sykes

When you want to delete rows it's better to start at the last row and go up. Your loop will miss some rows.

Try this simple test. Write in S2 and S3 "other - rubbish bin" and in S4 some other thing. Run your code and check that it missed one of the rows.

Also a loop is much less efficient than autofilter. I tried the codes with 10000 rows. The one with the loop took almost 30s (maybe my PC isn't the fastest). The one with the autofilter took less than 1s. Please try it. It will make you a fan of autofilter. I am.

Best regards
PGC
 

Forum statistics

Threads
1,136,368
Messages
5,675,358
Members
419,565
Latest member
Phil57

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Top