disable menu item - why doesn't this code work?

[Nick147]

This code doesn't work for some reason. I get a a runtime error "Invalid procedure or argument"

Sub disablemenutitems()
With Application.commandbars("Proposal").Controls
.Item("Enter/Edit Invoice Data...").Enabled = False
End With
End Sub

Sub enablemenuitems()
With Application.commandbars("Proposal").Controls
.Item("Enter/Edit Invoice Data...").Enabled = True
End With
End Sub

These two subs work fine if I use "File" in place of "Proposal" and "Print..." in place of "Enter/Edit Invoice Data...".

NL

 

[TommyGun]

Assuming that you actually have menus for "Proposal" on your main XL menu...this should work fine. However, there is no "real" need to inclose this within a With...End With block.

<font face=Courier New><SPAN style="color:#00007F">Sub</SPAN> DisableMenuItems()
    Application.CommandBars(1).Controls("Proposal").Controls("Enter/Edit Invoice Data...").enabled = <SPAN style="color:#00007F">False</SPAN>
<SPAN style="color:#00007F">End</SPAN> <SPAN style="color:#00007F">Sub</SPAN>

<SPAN style="color:#00007F">Sub</SPAN> EnableMenutItems()
    Application.CommandBars(1).Controls("Proposal").Controls("Enter/Edit Invoice Data...").enabled = <SPAN style="color:#00007F">True</SPAN>
<SPAN style="color:#00007F">End</SPAN> <SPAN style="color:#00007F">Sub</SPAN></FONT>

 

[Nick147]

Yes, the menus do actually exist. What could I possibly be missing or doing wrong?

NL

 

[TommyGun]

Did the code I provide not work?

 

[Nick147]

No it didn't work.

 

[TommyGun]

Where is your menu item "Proposal" located?

Also, do you have code that is creating these menus?

 

[Nick147]

"Proposal" is located between "Window" and "Help". Here is my code for creating the menu items.

Sub createmenu()
' CREATING THE MENU
Dim Helpmenu As CommandBarControl
Dim Newmenu As CommandBarPopup
Dim MenuItem As CommandBarControl
Dim Submenuitem As CommandBarButton
Call DeleteMenu
Set Helpmenu = commandbars(1).FindControl(ID:=30010)
If Helpmenu Is Nothing Then
Set Newmenu = commandbars(1).Controls _
.Add(Type:=msoControlPopup, temporary:=True)
Else
Set Newmenu = commandbars(1).Controls _
.Add(Type:=msoControlPopup, Before:=Helpmenu.Index, _
temporary:=True)
End If
Newmenu.Caption = ("&Proposal")
' CREATE "ENTER PROPOSAL CRITERIA" MENU ITEM
Set MenuItem = Newmenu.Controls.Add _
(Type:=msoControlButton)
With MenuItem
.Caption = "&Enter/Edit Proposal Criteria..."
.FaceId = 162
.OnAction = "Proposalcriteria"
End With
' CREATE "ENTER INVOICE DATA" MENU ITEM
Set MenuItem = Newmenu.Controls.Add _
(Type:=msoControlButton)
With MenuItem
.Caption = "&Enter/Edit Invoice Data..."
.FaceId = 162
.OnAction = "Invoicedata"

NL

 

[TommyGun]

Okay, then try this code...

Sub Test()
Application.CommandBars(1).Enabled = False
End Sub

What happens when you run this?

 

[Nick147]

The entire menu bar disappears.

 

[TommyGun]

Okay, now reset it by running that code with TRUE.

Now, try this code...

Sub Test2()
Application.CommandBars(1).Controls("Proposal").Enabled=False
End Sub

What happens now?