doesn't work properly

[fastbuck]

Hiall.

I put this together from bits that I found through a search. However it's not working. Can I please get some help.

Sub AAA_Move_Data_One()

Application.ScreenUpdating = False
ActiveSheet.Unprotect Password:=""

For Each cell In Range("G3:G12")
    If cell.Value = vbNullString Then
        cell.Value = Range("K9")
    Exit Sub
    End If
Next cell

For Each cell In Range("H3:H12")
    If cell.Value = vbNullString Then
        cell.Value = Range("L9")
        Exit Sub
    End If
Next cell

Range("G28").Select

ActiveSheet.Protect Password:=""
Application.ScreenUpdating = True

End Sub

 

[RoryA]

Could you give us a little more to go on? Like what the actual problem is?

 

[fastbuck]

Thanks for your reply. I'm not too good on explanations. I have 2 columns of figures (K9:L12) - I want to be able to put an option button at each row and have the macro move those 2 figures to the first blank cells at G3:H12.

I found this worked ok, but when I added the second part it still only executed the first part.

For Each cell In Range("G3:G12")
If cell.Value = vbNullString Then
cell.Value = Range("K9")
Exit Sub
End If
Next cell

Hope this makes some sort of sense. I guess I could do it with one button for each individual cell, but I though it could be combined somehow.

Thank you
N

 

[RoryA]

It's the Exit Sub line. You probably want this:

Sub AAA_Move_Data_One()

Application.ScreenUpdating = False
ActiveSheet.Unprotect Password:=""

For Each cell In Range("G3:G12")
    If cell.Value = vbNullString Then
        cell.Value = Range("K9")
    Exit For
    End If
Next cell

For Each cell In Range("H3:H12")
    If cell.Value = vbNullString Then
        cell.Value = Range("L9")
        Exit For
    End If
Next cell

Range("G28").Select

ActiveSheet.Protect Password:=""
Application.ScreenUpdating = True

End Sub

 

[fastbuck]

Geez mate you are a genius...fair dinkum as we would say here in Oz. That works perfectly, thank you.
Narelle

 

[RoryA]

Glad to help.