ElseIf works when conditions met, but debug halts even though condition not met

dazhoop

New Member
Joined
Oct 10, 2008
Messages
22
Hi. I am a beginner practicing with VBA. I am assigning macros to buttons to make a tennis scoreboard.

If my cells I2 and J2 both = "40" then my ElseIf works properly.

However, when it cycles through again the debug halts at the same ElseIf statement even though both conditions are no longer true, and I just can't figure out why.

( I know that it errors out when I2 = "Adv", I haven't gotten to that part yet, but when I2 = "40" and J2 = "Adv" I would expect it to move the next ElseIf after the one it gets stuck on)

Here is my macro. Hope my first attempt at pasting BB code comes through ok.


Hi. I am a beginner practicing with VBA. I am assigning macros to buttons to make a tennis scoreboard.

If my cells I2 and J2 both = "40" then my ElseIf works properly.

However, when it cycles through again the debug halts at the same ElseIf statement even though both conditions are no longer true, and I just can't figure out why.

( I know that it errors out when I2 = "Adv", I haven't gotten to that part yet, but when I2 = "40" and J2 = "Adv" I would expect it to move the next ElseIf after the one it gets stuck on)

Here is my macro. Hope my first attempt at pasting BB code comes through ok.


Sub Player1_InGame()
Dim Current1 As String * 3
Dim Current2 As String * 3
Current1 = Worksheets("Tracker").Range("I2")
Current2 = Worksheets("Tracker").Range("J2")
If Current1 = 0 Then
Worksheets("Tracker").Range("I2") = 15
ElseIf Current1 = 15 Then
Worksheets("Tracker").Range("I2") = 30
ElseIf Current1 = 30 Then
Worksheets("Tracker").Range("I2") = 40
ElseIf Current1 = 40 And Current2 = 40 Then
Worksheets("Tracker").Range("I2") = "'Adv"
ElseIf Current1 = 40 And Current2 = "Adv" Then
Worksheets("Tracker").Range("I2") = "'Adv"
Worksheets("Tracker").Range("J2") = 40
Else
Worksheets("Tracker").Range("I2") = 0
End If
End Sub
 
Last edited:

Excel Facts

Copy formula down without changing references
If you have =SUM(F2:F49) in F50; type Alt+' in F51 to copy =SUM(F2:F49) to F51, leaving the formula in edit mode. Change SUM to COUNT.
L

Legacy 68668

Guest
Why you dimmed both variables as String ?

You are comparing Numeric value with String value....

try dimention as Long or Integer
 
Upvote 0

c_m

Well-known Member
Joined
May 29, 2008
Messages
836
untested but try:
Rich (BB code):
Sub Player1_InGame()
    
    Set Current1 = Worksheets("Tracker").Range("I2")
    Set Current2 = Worksheets("Tracker").Range("J2")

    If Current1 = 0 Then
        Worksheets("Tracker").Range("I2") = 15
    Else
If Current1 = 15 Then
        Worksheets("Tracker").Range("I2") = 30
    Else
If Current1 = 30 Then
        Worksheets("Tracker").Range("I2") = 40
    Else
If Current1 = 40 And Current2 = 40 Then
        Worksheets("Tracker").Range("I2") = "Adv"
    Else
If Current1 = 40 And Current2 = "Adv" Then
        Worksheets("Tracker").Range("I2") = "Adv"
        Worksheets("Tracker").Range("J2") = 40
    Else
        Worksheets("Tracker").Range("I2") = 0
    End If
End If
End If
End If
End If

 End Sub

 
Upvote 0

dazhoop

New Member
Joined
Oct 10, 2008
Messages
22
c_m - I had already tried that with the same outcome.

Seiya,

Changing String to Variant is the answer and it works. May I ask why that is, for example, my "manual" says to avoid using Variant which is why I opted for String?

Thanks,

Darren
 
Upvote 0

Norie

Well-known Member
Joined
Apr 28, 2004
Messages
76,358
Office Version
  1. 365
Platform
  1. Windows
Try using Select...Case rather than If...ElseIf...End If.
 
Upvote 0
L

Legacy 68668

Guest
Darren

Variant is suppose to be used like this case.

Variant type variable, as you know, can hold any type of value.
So if it stores nuemric value, it turns Variant/Double
or if is stores String value, it turns Variant/String

Therefore, it can be compared with both type of data.

By the way, why did you dimentioned your variable in 3 bytes of String type ?
As string * 3
 
Upvote 0

dazhoop

New Member
Joined
Oct 10, 2008
Messages
22
Seiya - OK, that makes sense with the Variant definition.

I chose String * 3 as I figured that the biggest value I would have in my Dim was there characters (Adv) - I get the feeling my logic is flawed there?

Norie - I haven't got as far as learning about VBA Case yet, but as I use it frequently in Unix scripting, it will no doubt end up being my preferred choice of command.
 
Upvote 0
L

Legacy 68668

Guest
Darren

It sure minimize the usage of the memory for that variable, however you will need to adjust * 3 part as the variable length need to be expand and memory these days is suffient to hold.

I only use that type of dim statement when I need to ristrict the value in 3 bytes for the output purpose only.
 
Upvote 0

Forum statistics

Threads
1,190,921
Messages
5,983,595
Members
439,852
Latest member
balasat

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Top