Enabling a Button based on multiple Changes to Userform

[Hitman51]

0
I am trying to keep a button disabled until all required fields are completed. I have the button disabled at initialize and I can get it to enable with one field completed using the code below. How do I add the other fields that are required to be completed?

`Private Sub Findings_Change()
    If Findings.Value <> "" Then
        btnOk.Enabled = True
        Else: btnOk.Enabled = False
    End If
End Sub`

I tried the following, but it enables the button after one field is completed and not all three. Note Findings and CompletionTime are textboxes in the userform, Failure is a listbox. Please HELP!

Private Sub Findings_Change()
    If Findings.Value <> "" Then
        btnOk.Enabled = True
        Else: btnOk.Enabled = False
    End If
End Sub
Private Sub Failure_Change()
    If Failure.Value <> "" Then
        btnOk.Enabled = True
        Else: btnOk.Enabled = False
    End If
End Sub
Private Sub CompletionTime_Change()
    If CompletionTime.Value <> "" Then
        btnOk.Enabled = True
        Else: btnOk.Enabled = False
    End If
End Sub

 

[Hitman51]

Try this update

Sub AllComplete()
    Me.btnOk.Enabled = Len(Me.findings.Value) > 0 And _
    Len(Me.failure.Value) > 0 And Len(Me.completiontime.Value) > 0
End Sub

Dave

Dave, I greatly appreciate the continued help, however the error is still popping up on this portion of the code.

 

[dmt32]

Dave, I greatly appreciate the continued help, however the error is still popping up on this portion of the code.

A bit messy but see if this resolves the issue but if not, helpful if could place copy of your workbook with dummy data in a file sharing site like dropbox & provide a link to it.

Sub AllComplete()
    Dim ctrl As Variant
    For Each ctrl In Array(Me.findings, Me.failure, Me.completiontime)
     With Me.btnOk
        .Enabled = Len(ctrl.Value) > 0
        If Not .Enabled Then Exit For
     End With
    Next ctrl
End Sub

Dave

 

[Hitman51]

A bit messy but see if this resolves the issue but if not, helpful if could place copy of your workbook with dummy data in a file sharing site like dropbox & provide a link to it.

Sub AllComplete()
    Dim ctrl As Variant
    For Each ctrl In Array(Me.findings, Me.failure, Me.completiontime)
     With Me.btnOk
        .Enabled = Len(ctrl.Value) > 0
        If Not .Enabled Then Exit For
     End With
    Next ctrl
End Sub

Dave

Thanks Dave. The problem still persists. The link to the file at Dropbox is below. Please see my notes below the link for details.

2023 RMA V2.7.14_Dummy File.xlsm

On the Dashboard, please enter 22-432 into the box at the top of the page. Once entered, if you click on the button labeled "Complete RMA" it will pop up the userform. I begin entering values and usually the message pops up on my VB screen when I get to the field called "Findings". If it doesn't pop up, I hit cancel and try again. It sometimes takes a few tries to get the error to pop up. DO NOT PRESS OK button or it will change a field in the spreadsheet and prevent you from getting back to the userform. Again, I usually just hit cancel and try again. If it doesn't pop up within about 8-12 tries I would assume it is fixed.

 

[dmt32]

Hi,
Your control Failure included in the AllComplete code is a listbox - solutions provided were based on your original post suggesting all were textboxes.

See if this update now resolves

Sub AllComplete()
    Me.btnOk.Enabled = CBool(Me.Findings.Value <> "" And _
                             Me.CompletionTime.Value <> "" And _
                             Me.Failure.ListIndex <> -1)
End Sub

As you can see, control Failure requires a different test to the textboxes to establish if a selection / entry has been made.

Hope Helpful

Dave

 

[Hitman51]

Hi,
Your control Failure included in the AllComplete code is a listbox - solutions provided were based on your original post suggesting all were textboxes.

See if this update now resolves

Sub AllComplete()
    Me.btnOk.Enabled = CBool(Me.Findings.Value <> "" And _
                             Me.CompletionTime.Value <> "" And _
                             Me.Failure.ListIndex <> -1)
End Sub

As you can see, control Failure requires a different test to the textboxes to establish if a selection / entry has been made.

Hope Helpful

Dave

Dave, Thank you. This resolved the issue.

Just for reference, I did mention on the original post that one of them was a listbox, however I may not have done it clearly enough. Thank you again for your help, it was GREATLY Appreciated.

I have one other Item I am not sure how to set up so I will do a new post on that topic. Thanks again!

 

[dmt32]

Dave, Thank you. This resolved the issue.
I did mention on the original post that one of them was a listbox

so you did - I should have read the whole post - sorry about that!

As a tip, it's good that you have given your controls appropriate names but may want to consider applying a naming convention that identifies the control type

for example a you would name the control lstFailure which indicates that it is a listbox.

You can read more here: User Form object naming conventions

Glad now resolved & appreciate feedback

Dave

 

[Hitman51]

so you did - I should have read the whole post - sorry about that!

As a tip, it's good that you have given your controls appropriate names but may want to consider applying a naming convention that identifies the control type

for example a you would name the control lstFailure which indicates that it is a listbox.

You can read more here: User Form object naming conventions

Glad now resolved & appreciate feedback

Dave

That is great feedback. I will use that going forward. thank you!