Error handler close workbook if opened during code

[rhombus4]

During my code if there is an error it jumps to errorhandler which will close a workbook if it was opened during the code. If it wasn't opened it can just ignore it
However I get run time error 9 subscript out of range on the set wb line in eh:

Sub test()
On error goto eh
Code

Dim wb as workbook
Set wb = workbooks.open("c:\test.xlsx")

Some more code

Exit sub

eh:
On error resume next
Set wb = workbooks("test.xlsx")
wb.close
On error goto 0

End sub

 

[Fluff]

How about

eh:
   If Not wb Is Nothing Then wb.Close
End Sub

 

[rhombus4]

Does your one line of code replace everything I had before. does it not need an on error resume next before it.

Also, If an error was caused before the
Set wb = workbooks.open("c:\test.xlsx")
Do I need to declare again before the
If Not wb Is Nothing Then wb.Close

As It doesn't close the workbook

 

[Fluff]

Just replace this

eh:
On error resume next
Set wb = workbooks("test.xlsx")
wb.close
On error goto 0

End sub

with the code I suggested.

 

[rhombus4]

But if the test workbook was already open it won't close if an error happened before it was set

E.g.

Sub test()
On error goto eh
X  = 1/0

Dim wb as workbook
Set wb = workbooks.open("c:\test.xlsx")

Some more code

Exit sub

eh:
If Not wb Is Nothing Then wb.Close
End sub

 

[Fluff]

Why would you be opening a workbook if it was already open?

 

[rhombus4]

Why would you be opening a workbook if it was already open?

Good point lol

PS, I didn't understand how it could close wb if wb hadn't been set as the error didn't get that far and jumped to eh:

It's more a case of if the code opens and closes multiple workbooks and an error occurred. Could be anywhere

So Would it just be
Eh:
If Not wb1 Is Nothing Then wb1.Close
If Not wb2 Is Nothing Then wb2.Close
If Not wb3 Is Nothing Then wb3.Close

And would close wb1 wb2 wb3 if they were opened and ignore if they weren't

 

[Fluff]

That's right, as you are setting the variable when the workbook is opened, if the code fails before a workbook is opened then wb1 will be Nothing

 

[rhombus4]

Thanks Fluff
So many different answers online which didn't work for me. Yours seemed to work ??

Marked your first reply as solved

 

[Fluff]

Glad to help & thanks for the feedback.