Error "Method 'SaveAs' of object '_Workbook" failed

[juanbolas]

Hello,

I'm trying to generate a series of Excel (*.xlsx) files and am getting this error when trying to save the file.

I've taken out the non-offending code to make it simpler

Any help is appreciated.

Sub PDP_RequestQuotes()

Dim CurRow As Integer

For Each cProveedor In ActiveWorkbook.Sheets("Unique").Range("ProveedoresUnique")
  
    Debug.Print cProveedor.Value
  
    Proveedor = ThisWorkbook.Sheets("Form_PDP").Range("E5").Value
    FilePath = "C:\Users\me\OneDrive\Escritorio\"
    FileName = Year(Date) & Right("00" & Len(Month(Date)), 2) & Right("00" & Len(Day(Date)), 2) & " - " & Proveedor & ".xlsx"
   
    ThisWorkbook.Sheets("Form_PDP").Copy
    ThisWorkbook.SaveAs FileName:=FilePath & FileName, FileFormat:=1
    ThisWorkbook.Close False

Next cProveedor

End Sub

 

[Joe4]

I am not sure if this is exactly what is causing your issue, but it is generally a bad idea to choose variables names that are exactly the same as arguments in your code, i.e.

    ThisWorkbook.SaveAs FileName:=FilePath & FileName, FileFormat:=1

And I do not see "1" as a valid option for the "FileFormat" argument.
Here is a list of the different FileFormat codes: XlFileFormat enumeration (Excel)

So see if this works better (untested):

Sub PDP_RequestQuotes()

Dim CurRow As Integer
Dim Proveedor as String
Dim cProvedor as Range
Dim myFilePath as String
Dum myFileName as String

For Each cProveedor In ActiveWorkbook.Sheets("Unique").Range("ProveedoresUnique")
 
    Debug.Print cProveedor.Value
 
    Proveedor = ThisWorkbook.Sheets("Form_PDP").Range("E5").Value
    myFilePath = "C:\Users\me\OneDrive\Escritorio\"
    myFileName = Year(Date) & Right("00" & Len(Month(Date)), 2) & Right("00" & Len(Day(Date)), 2) & " - " & Proveedor & ".xlsx"
  
    ThisWorkbook.Sheets("Form_PDP").Copy
    ThisWorkbook.SaveAs FileName:=myFilePath & myFileName, FileFormat:=51
    ThisWorkbook.Close False

Next cProveedor

End Sub

 

[juanbolas]

Thank you!

 

[Joe4]

You are welcome.
So did that solve the issue?