Excel Shapes?

[Kariya]

Hi all,

I have the following VBA code which assigns the variable "Data" with the value of the Shape called "Box" on my sheet. It's generated by the Macro Recorder. However, when running it, it selects the box. How do I re-write it to exclude the "Select" suffix?

   Worksheets("Sheet1").Activate
    ActiveSheet.Shapes.Range(Array("Box")).Select
    Data = Selection.ShapeRange(1).TextFrame2.TextRange.Characters

Thanks for the help!

 

[John_w]

    Data = ActiveSheet.Shapes.Range(Array("Box")).TextFrame2.TextRange.Characters

 

[Kariya]

    Data = ActiveSheet.Shapes.Range(Array("Box")).TextFrame2.TextRange.Characters

Thank you! Appreciate it.

 

[Smitty]

The general rule of thumb is that when you see Select followed by Selection you can eliminate both statements and pull together the remainder. Shapes and charts are often the exception though, as they don't always like not being selected first.

 

[Kariya]

The general rule of thumb is that when you see Select followed by Selection you can eliminate both statements and pull together the remainder. Shapes and charts are often the exception though, as they don't always like not being selected first.

I see Thank you for the tip. I tried different variations - but to no avail, was close enough though. I'm forcing myself to learn VBA by doing something that I have an interest in. In this case, reading CSV/TXT soccer/football historical data from here and aggregating the results with the options of viewing each round of the league & selecting the range of games for the "recent form". It's working as I'm finally learning

 

[Smitty]

I tried different variations - but to no avail, was close enough though. I'm forcing myself to learn VBA by doing something that I have an interest in.

Looks like you're doing a great job!

When I'm teaching Excel classes and we get to VBA I always tells people that the Macro Recorder is your friend, but while you're learning, you should definitely record processes with which you're intimately familiar. That way the code makes sense to you when you try to read it.