exit sub routine to goto next loop

[SQUIDD]

Hi All

So im wondering how best to tackle this.

Im checking through data and i an checking if scenarios are met.

for example, a very simplified example below.

in fact while writing the example i had a little idea about declaring a global flag status of some description, then if the flag is activate, simple check this at the top of all the check macros, and simply use exit sub

but i still wonder if there is another or better way.

i hope this makes sense, but ultimatly if any of the check subs are unsatisfied, we literally skip to the next A in sub TT

thanks for looking, oh yes, i do not want to write it into 1 sub either and use goto, i have far too many checks to write it that long and confusing.

Dave

Sub TT()
For a = 1 To 100
    If b = 1 Then Call check1
    If c = 1 Then Call check2
    If d = 1 Then Call check3
    If e = 1 Then Call check4
    If f = 1 Then Call check5
    'skip to here if checks not satisfied
Next a
End Sub
Sub check1()
If f = 6 Then 'at this point exit the sub, but also do not action any more of the calls, so next A in sub TT
End Sub
Sub check2()
If f = 6 Then 'at this point exit the sub, but also do not action any more of the calls, so next A in sub TT
End Sub
Sub check3()
If f = 6 Then 'at this point exit the sub, but also do not action any more of the calls, so next A in sub TT
End Sub
Sub check4()
If f = 6 Then 'at this point exit the sub, but also do not action any more of the calls, so next A in sub TT
End Sub
Sub check5()
If f = 6 Then 'at this point exit the sub, but also do not action any more of the calls, so next A in sub TT
End Sub
Sub check6()
If f = 6 Then 'at this point exit the sub, but also do not action any more of the calls, so next A in sub TT
End Sub

 

[SQUIDD]

ok, well setting a flag status worked really well, so posted it as example, i am happy with it

PUBLIC FLAG As Integer    
Sub TT()
For a = 1 To 100
FLAG = 0
If b = 1 Then Call check1
If c = 1 Then Call check2
If d = 1 Then Call check3
If e = 1 Then Call check4
If f = 1 Then Call check5
'skip to here if checks not satisfied
Next a
End Sub
Sub check1()
IF FLAG = 1 THEN EXIT SUB
If f = 6 Then FLAG =1:EXIT SUB
End Sub
Sub check2()
IF FLAG = 1 THEN EXIT SUB
If f = 6 Then FLAG =1:EXIT SUB
End Sub
Sub check3()
IF FLAG = 1 THEN EXIT SUB
If f = 6 Then FLAG =1:EXIT SUB
End Sub
Sub check4()
IF FLAG = 1 THEN EXIT SUB
If f = 6 Then FLAG =1:EXIT SUB
End Sub
Sub check5()
IF FLAG = 1 THEN EXIT SUB
If f = 6 Then FLAG =1:EXIT SUB
End Sub
Sub check6()
IF FLAG = 1 THEN EXIT SUB
If f = 6 Then FLAG =1:EXIT SUB
End Sub

 

[6StringJazzer]

Yeah, that works, but it is not good software design. It uses common environment coupling, an undesirable type of coupling. I would recommend this more structure approach:

Sub TT()

   Dim SubFailure As Boolean

   For a = 1 To 100
   
       SubFailure = False
       
       If b = 1 And Not SubFailure Then check1 SubFailure
       If c = 1 And Not SubFailure Then check2 SubFailure
       If d = 1 And Not SubFailure Then check3 SubFailure
       If e = 1 And Not SubFailure Then check4 SubFailure
       If f = 1 And Not SubFailure Then check5 SubFailure
       'skip to here if checks not satisfied
       
   Next a

End Sub
Sub check1(SubFailure As Boolean)
   If f = 6 Then
      SubFailure = True   'at this point exit the sub, but also do not action any more of the calls, so next A in sub TT
   Else
      ' do your other stuff here
   End If
End Sub
Sub check2(SubFailure As Boolean)
   If f = 6 Then
      SubFailure = True   'at this point exit the sub, but also do not action any more of the calls, so next A in sub TT
   Else
      ' do your other stuff here
   End If
End Sub
Sub check3(SubFailure As Boolean)
   If f = 6 Then
      SubFailure = True   'at this point exit the sub, but also do not action any more of the calls, so next A in sub TT
   Else
      ' do your other stuff here
   End If
End Sub
Sub check4(SubFailure As Boolean)
   If f = 6 Then
      SubFailure = True   'at this point exit the sub, but also do not action any more of the calls, so next A in sub TT
   Else
      ' do your other stuff here
   End If
End Sub
Sub check5(SubFailure As Boolean)
   If f = 6 Then
      SubFailure = True   'at this point exit the sub, but also do not action any more of the calls, so next A in sub TT
   Else
      ' do your other stuff here
   End If
End Sub
Sub check6(SubFailure As Boolean)
   If f = 6 Then
      SubFailure = True   'at this point exit the sub, but also do not action any more of the calls, so next A in sub TT
   Else
      ' do your other stuff here
   End If
End Sub