For loops and random numbers

[Darkpagey]

Hey guys.

I've got the following code (variables declared previously):

ReDim A(i) As Integer
For i = 1 To n
[COLOR=#ff0000]    A(i) = i[/COLOR]
Next i


For i = 1 To n
    r = Int((n - i + 1) * Rnd() + i)
    y = A(i)
    A(i) = A(r)
    A(r) = y
    Cells(i).Value = A(i)
Next i

This creates (in this case for my data, n=4) 4 numbers between 1 and 4 which have been swapped in a random fashion to create a random permutation.

What I want to achieve is a set of random numbers from i = 1 to n^2 (as opposed to from i = 1 to n). However, when I try to do this, the line which I have highlighted above gives error 9 (subscript out of range)

Sorry for this being such a pedestrian question, but how do I get around this?

 

[engineer69]

Have you tried:
Dim A(1000) As Integer?
Not sure if 1000 is large enough, but your ReDim statement does not contain a size or you might try to declare it "As Variant"

 

[shg]

    Dim A()         As Integer
    Dim n           As Long

    ReDim A(1 To n)
    ' or
    ReDim A(1 To n ^ 2)

 

[Darkpagey]

:S Oh man that's so easy, thanks guys.

 

[shg]

You have to assign a value to n >=1 first -- I should have shown that.