For...Next

[RTHoward]

I have the following table:

a b c d
-------
1|- - x -
2|- - - -
3|- - x -
4|- - - -

I want to write VBA that will delete those rows where the value in column c = "x". I need to write it so that the code will work on any table (using CurrentRegion or UsedRange).

I tried the following, but it didn't work properly; it skipped row 3.

Sub Delete_X()
Dim tbl As Object
Dim rw As Object
Dim DateRet

Worksheets("Sheet1").Range("a1").Activate
Set tbl = ActiveCell.CurrentRegion

For Each rw In tbl.Rows
DateRet = rw.Cells(1, 3).Value
If DateRet = "x" Then rw.Delete
Next

End Sub


Any help would be greatly appreciated.

 

[attc]

this problem somehow wasn't as simple as it first looked. I originally thought the problem was with the currentregion not doing what you wanted, but when I tried using a for each c in selection type loop, it skipped any lines immediately following another x.

the following isn't elegant but should work.

Sub del_x()

Dim LastCell As Range
Dim A As Integer
Dim noX As Integer

noX = 0

Cells.Find(What:="*", After:=Range("A1"), SearchDirection:=xlPrevious).Select

Set LastCell = ActiveCell

For A = 1 To LastCell.Row

If Cells(A - noX, 3).Value = "x" Then
Cells(A - noX, 3).EntireRow.Delete
noX = noX + 1
End If

Next

End Sub

 

[ChrisM]

Instead of using regions and tables, have you considered the find command with column c? everytime you find an 'x' in column c, delete that row. Or if not column c, then some range of c like c1:c150 etc, etc.

something like:

set search = worksheets("sheet1").range("c:c").find ("x", lookin:=xlvalues)

if not search is nothing then
'your delete code here

etc, etc

end if

 

[RTHoward]

Thanks. Even if it's not elegant, it still worked. Kind of like my golf-game...

 

[straus]

who says taht that was not elegant???

 

[RTHoward]

"attc" did in his post above. No harm was meant by my comment. The code works beautifully.