Forcing userform text boxes to be filled

[scoha]

I have a user form with a number of text boxes that are mandatory and have come up with some code that I thought was a neat way of checking these mandatory boxes for a value before the user form is advanced to the next record - but I gey a type mismatch error and cannot understand why - any one help me?:

Mandatory text boxes are txtTot, txtAddress1, txtCon etc

Private Function CheckComplete()

Dim cCont As Control

    For Each cCont In Me.Controls
           If cCont.Name = "txtTot" Or "txtAddress1" Or "txtCon" Then
            If cCont.Value = "" Then MsgBox "You need to fill in " & cCont.Name
            End If
     Next cCont

End Function

 

[northwolves]

Try

Sub CheckComplete()

    Dim cCont As Control

    For Each cCont In Me.Controls
        If TypeName(cCont) = "TextBox" Then
            If cCont.Text = "" Then MsgBox "You need to fill in " & cCont.Name: cCont.SetFocus: Exit Sub
        End If
    Next cCont

End Sub

Regards
Northwolves

 

[Norie]

Try this.

Private Sub CheckComplete()
Dim cCont As Control
    For Each cCont In Me.Controls
           Select Case cCont.Name
                Case "txtTot", "txtAddress1", "txtCon"
                    If cCont.Value = "" Then MsgBox "You need to fill in " & cCont.Name
                Case Else
                    'do nothing
            End Select
     Next cCont
End Sub

 

[mikerickson]

The line

If cCont.Name = "txtTot" Or "txtAddress1" Or "txtCon" Then

is causing the type mismatch error

OR is a operation on two Boolean values and the string "txtAddress1" is not Boolean.

Nothwolves' solution avoids the clumbsy expression

If (cCont.Name = "txtTot") Or (cCont.Name  = "txtAddress1") Or (cCont.Name = "txtCon") Then

While Norie's handles the situation where the UF has more than those three textboxes.