Function doesnt working

[cvelle89]

Hello.
I want from each cell in range A:A, to check the last letter, and if it is an "a" letter to substitute with letter "e" and to enter it in Cell (B & i)

here is the working code for all other letter except this letter "a" at the end

Sub stov()

Dim LR As Long, i As Long
Application.ScreenUpdating = False
LR = Range("A" & Rows.Count).End(xlUp).Row




For i = 1 To LR
    With Range("A" & i)
    If Right(.Value, 1) = "o" Then Cells(i, 2).Value = Left(.Value, Len(.Value) - 1) & "a"    'genitiv od koga?od cega?
    If Right(.Value, 1) = "a" Then Cells(i, 2).Value = Left(.Value, Len(.Value)-1) & "e"
      ' If Right(.Value, 1) = "n" Then Cells(i, 2).Value = Left(.Value, Len(.Value)) & "a"
     '   If Right(.Value, 1) = "v" Then Cells(i, 2).Value = Left(.Value, Len(.Value)) & "a"
           '  If Right(.Value, 1) = "e" Then Cells(i, 2).Value = Left(.Value, Len(.Value) - 1) & "a"
     '   If Right(.Value, 1) = "r" Then Cells(i, 2).Value = Left(.Value, Len(.Value)) & "a"
     '   If Right(.Value, 1) = "b" Then Cells(i, 2).Value = Left(.Value, Len(.Value) - 1) & "a"
    If Right(.Value, 1) = "m" Then Cells(i, 2).Value = Left(.Value, Len(.Value)) & "a"
     '   If Right(.Value, 1) = "e" Then Cells(i, 2).Value = Left(.Value, Len(.Value) - 1) & "a"
         
        ' If Right(.Value, 1) = "j" Then Cells(i, 2).Value = Left(.Value, Len(.Value)) & "a"
        
    End With
    
    With Range("B" & i)
    
       ' If Right(.Value, 1) = Right(.Value, 2) Then Cells(i, 3).Interior.Color = RGB(255, 0, 0)
    
    End With
    
Next i
Application.ScreenUpdating = True
End Sub

Thanks!

 

[steve the fish]

Your code for "a" just says len(.value). Needs to be len(.value)-1

 

[cvelle89]

yeah, I've noticed that, I edit my code here on this topic as well as in VBA. The result is the same. All other functions in the code are doing just fine... this so buggy

 

[steve the fish]

If the code finds 'blua' in column A it will put 'blue' in column B of the same row. Is that what you think is supposed to happen?

 

[cvelle89]

Precisely

 

[Jonmo1]

Your code does exactly that when I run it (with the correction steve pointed out needing the -1 after the LEN)

 

[cvelle89]

on my machine, it runs code for every other function quite well..except for the **** "a"

Ok, thanks..I will try on another machine or to restart the pogram.

Thanks again

 

[steve the fish]

Enter the cell where you think it isn't working. Test it for trailing spaces. Then of course right() would produce a space not 'a'.

 

[Jonmo1]

One thing that might trip it up is that VBA tends to be Case Sensitive.

So if you had say ALOHA
Then = "a" would be false.

Try
If Lcase(Right(.Value, 1)) = "a" Then