grouping error

[jasman]

Hi. I have some images which I have written code to group them when a command button is clicked. but it also groups the command button with the images- anyway around this? Heres my code?

Thanks


Private Sub CommandButton2_Click()
Sheets("Sheet2").Select
ActiveSheet.Shapes.SelectAll
Selection.ShapeRange.GROUP.Select
End Sub

the error says:
the specified parameter has an invalid value
runtime error 1004
<!-- / message -->

 

[MickG]

Try this:-

[COLOR="Navy"]Sub[/COLOR] MG14Mar21
[COLOR="Navy"]Dim[/COLOR] c [COLOR="Navy"]As[/COLOR] [COLOR="Navy"]Integer[/COLOR]
[COLOR="Navy"]Dim[/COLOR] Pic [COLOR="Navy"]As[/COLOR] Shape
[COLOR="Navy"]Dim[/COLOR] Ray()
[COLOR="Navy"]Dim[/COLOR] p [COLOR="Navy"]As[/COLOR] [COLOR="Navy"]Integer[/COLOR]
p = 0
[COLOR="Navy"]For[/COLOR] [COLOR="Navy"]Each[/COLOR] Pic [COLOR="Navy"]In[/COLOR] ActiveSheet.Shapes
    [COLOR="Navy"]If[/COLOR] Pic.Type = msoPicture [COLOR="Navy"]Then[/COLOR]
        ReDim Preserve Ray(p)
        Ray(p) = Pic.Name
        p = p + 1
    [COLOR="Navy"]End[/COLOR] If
[COLOR="Navy"]Next[/COLOR] Pic
ActiveSheet.Shapes.Range(Ray).Group.Select
     MsgBox Selection.Name
'[COLOR="Green"][B]Selection.Ungroup[/B][/COLOR]
[COLOR="Navy"]End[/COLOR] [COLOR="Navy"]Sub[/COLOR]

Regards Mick

 

[jasman]

works a treat, thank you very much

 

[jasman]

what would be the code to ungroup?
also, when I click another command button which created the images, it has some code at the beginning to clear the current images on the page- but it also clears the command button. Is there anyway to fix this command button so no chnages can be made to it?

thanks again

 

[jasman]

-

 

[MickG]

Try the 2 codes below, Boith run from "CommandButtons" ,One to Ungroup a "Group", and the other to delete Pictures.

Private Sub CommandButton2_Click()
Dim Grp As Shape
For Each Grp In ActiveSheet.Shapes
    If Grp.Type = msoGroup Then
        Grp.Ungroup
    End If
Next Grp
End Sub

Private Sub CommandButton3_Click()
Dim Pic As Shape
For Each Pic In ActiveSheet.Shapes
    If Pic.Type = msoPicture Then
       Pic.Delete
    End If
Next Pic
End Sub

Mick

 

[jasman]

hi thanks for the reply. it works to ungroup but the delete pictures doesnt work?

 

[MickG]

The delete Pictures "Code" will not work if the pictures are still a Group. You need to ungroup them first.
Mick

 

[jasman]

great thanks that works a treat