Help : Combining Function and Sub

rizalyaakub

New Member
Joined
Nov 6, 2022
Messages
3
Office Version
  1. 2021
Platform
  1. Windows
Hi! I am rather new at excel, I am trying to combine a number to text function, and a sub to extract data in invoice sheet into Data List. Individually they work ok, however when combined this pops out
pop.png


Anyone can help me to fix this?

VBA Code:
Option Explicit
Dim invnum As String
Dim invdate As Date
Dim sjrref As String
Dim clientref As String
Dim client As String
Dim matter As String
Dim fees As Currency
Dim nextrec As Range
Dim path As String
Dim fname As String

Sub RecordofInvoice()

invnum = Range("G4")
invdate = Range("G6")
sjrref = Range("G11")
clientref = Range("G10")
client = Range("B7")
matter = Range("B13")
fees = Range("G29")

Set nextrec = Sheet4.Range("A1048").End(xlUp).Offset(1, 0)

nextrec = invnum
nextrec.Offset(0, 1) = invdate
nextrec.Offset(0, 2) = sjrref
nextrec.Offset(0, 3) = clientref
nextrec.Offset(0, 4) = matter
nextrec.Offset(0, 5) = fees

End Sub
Function SpellNumberToEnglish(ByVal pNumber)
'Update by Extendoffice
Dim Dollars, Cents
arr = Array("", "", " Thousand ", " Million ", " Billion ", " Trillion ")
pNumber = Trim(Str(pNumber))
xDecimal = InStr(pNumber, ".")
If xDecimal > 0 Then
    Cents = GetTens(Left(Mid(pNumber, xDecimal + 1) & "00", 2))
    pNumber = Trim(Left(pNumber, xDecimal - 1))
End If
xIndex = 1
Do While pNumber <> ""
    xHundred = ""
    xValue = Right(pNumber, 3)
    If Val(xValue) <> 0 Then
        xValue = Right("000" & xValue, 3)
        If Mid(xValue, 1, 1) <> "0" Then
            xHundred = GetDigit(Mid(xValue, 1, 1)) & " Hundred "
        End If
        If Mid(xValue, 2, 1) <> "0" Then
            xHundred = xHundred & GetTens(Mid(xValue, 2))
        Else
            xHundred = xHundred & GetDigit(Mid(xValue, 3))
        End If
    End If
    If xHundred <> "" Then
        Dollars = xHundred & arr(xIndex) & Dollars
    End If
    If Len(pNumber) > 3 Then
        pNumber = Left(pNumber, Len(pNumber) - 3)
    Else
        pNumber = ""
    End If
    xIndex = xIndex + 1
Loop
Select Case Dollars
    Case ""
        Dollars = ""
    Case "One"
        Dollars = "One"
    Case Else
        Dollars = Dollars & ""
End Select
Select Case Cents
    Case ""
        Cents = ""
    Case "One"
        Cents = " and One Sen"
    Case Else
        Cents = " and " & Cents & " Sen"
End Select
SpellNumberToEnglish = Dollars & Cents
End Function
Function GetTens(pTens)
Dim Result As String
Result = ""
If Val(Left(pTens, 1)) = 1 Then
    Select Case Val(pTens)
        Case 10: Result = "Ten"
        Case 11: Result = "Eleven"
        Case 12: Result = "Twelve"
        Case 13: Result = "Thirteen"
        Case 14: Result = "Fourteen"
        Case 15: Result = "Fifteen"
        Case 16: Result = "Sixteen"
        Case 17: Result = "Seventeen"
        Case 18: Result = "Eighteen"
        Case 19: Result = "Nineteen"
        Case Else
    End Select
Else
Select Case Val(Left(pTens, 1))
    Case 2: Result = "Twenty "
    Case 3: Result = "Thirty "
    Case 4: Result = "Forty "
    Case 5: Result = "Fifty "
    Case 6: Result = "Sixty "
    Case 7: Result = "Seventy "
    Case 8: Result = "Eighty "
    Case 9: Result = "Ninety "
    Case Else
End Select
Result = Result & GetDigit(Right(pTens, 1))
End If
GetTens = Result
End Function
Function GetDigit(pDigit)
Select Case Val(pDigit)
    Case 1: GetDigit = "One"
    Case 2: GetDigit = "Two"
    Case 3: GetDigit = "Three"
    Case 4: GetDigit = "Four"
    Case 5: GetDigit = "Five"
    Case 6: GetDigit = "Six"
    Case 7: GetDigit = "Seven"
    Case 8: GetDigit = "Eight"
    Case 9: GetDigit = "Nine"
    Case Else: GetDigit = ""
End Select
End Function
 

Excel Facts

Easy bullets in Excel
If you have a numeric keypad, press Alt+7 on numeric keypad to type a bullet in Excel.

abdelfattah

Well-known Member
Joined
May 3, 2019
Messages
1,297
Office Version
  1. 2019
Platform
  1. Windows
Hi
this suggestion is not guaranteed ,but just try declaration for variable arr
VBA Code:
  Dim arr As Variant
 
Upvote 0

Alex Blakenburg

MrExcel MVP
Joined
Feb 23, 2021
Messages
6,146
Office Version
  1. 365
Platform
  1. Windows
You will need to add all of these below your Dim Dollars, Cents.

I think all your values are whole numbers so I have used Long.

VBA Code:
Dim arr As Variant
Dim xDecimal As Long
Dim xIndex As Long
Dim xHundred As Long
Dim xValue As Long
 
Upvote 0
Solution

Forum statistics

Threads
1,186,441
Messages
5,957,870
Members
438,329
Latest member
Aimon Rauf

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Top