Help with on error goto

[nehpets12]

In this code I have to Error Traps the first On Error GoTo 1 the second On Error GoTo 2 Why does this come up with an error I have not set up any DIM statements could this be the cause of the error code runtime error 91

Sub Find_Chassis_No()


    On Error GoTo 1
    Application.ScreenUpdating = False
    Application.CutCopyMode = False
    MyReg = Range("C18").Value
    Sheets("Allmachines Copy").Select
    Columns("M:M").Select
    Selection.Find(What:=MyReg, After:=ActiveCell, LookIn:=xlFormulas, _
        LookAt:=xlPart, SearchOrder:=xlByRows, SearchDirection:=xlNext, _
        MatchCase:=False, SearchFormat:=False).Activate
    MyWK = Format(ActiveCell.Offset(0, -11).Value, "")


1   If MyWK > 0 Then GoTo 2
    On Error GoTo 2
    Sheets("Registration Numbers").Select
    Columns("G:G").Select
    Selection.Find(What:=MyReg, After:=ActiveCell, LookIn:=xlFormulas, _
        LookAt:=xlPart, SearchOrder:=xlByRows, SearchDirection:=xlNext, _
        MatchCase:=False, SearchFormat:=False).Activate
    MyID = ActiveCell.Offset(0, -3).Value
    Columns("A:A").Select
    Selection.Find(What:=MyID, After:=ActiveCell, LookIn:=xlFormulas, _
        LookAt:=xlPart, SearchOrder:=xlByRows, SearchDirection:=xlNext, _
        MatchCase:=False, SearchFormat:=False).Activate
    MyWK = Format(ActiveCell.Offset(0, 1).Value, "")




2   Range("A1").Select
    Sheets("Details").Select
    Range("B7").Value = MyWK
    Range("C18").Value = ""
    Range("C18").Select
    Application.ScreenUpdating = True
End Sub

 

[Norie]

Stephen

Why use On Error/GoTo in the first place?

If as I suspect the reason for the error(s) is that nothing is being found why not check that?

For example.

Dim rngFnd As Range

    Application.ScreenUpdating = False
    Application.CutCopyMode = False
    MyReg = Range("C18").Value
    Set rngFnd = Sheets("Allmachines Copy").Columns("M:M").Find(What:=MyReg, After:=ActiveCell, LookIn:=xlFormulas, _
        LookAt:=xlPart, SearchOrder:=xlByRows, SearchDirection:=xlNext, _
        MatchCase:=False, SearchFormat:=False)
        
    If Not rngFnd Is Nothing Then MyWK = Format(rngFnd.Offset(0, -11).Value, "")

PS What's the purpose of the Format?

 

[nehpets12]

Thank you for your quick response

you are correct I was only using the on error was that the data was not found I was not sure how to set it up to find nouthing, this has helped enormously thank you

The reason for the format was that the data it was searching was 004285
but I only wanted to copy it as a number ie 4285

 

[Norie]

Stephen

Well if you wanted a number you wouldn't use Format.

As far as I'm aware Format returns string values.

Try Val or CInt or CLng.

 

[nehpets12]

When I run your sample code I get a run time error 13 type mismatch Help please