Help with Protecting/Unprotecting worksheets in VBA

[JakeVBA2009]

Hi guys, I've got this code that i'm using to try and protect worksheets but i've got a small problem...I cant seem to make the code recognise that only 1 password will work in order to allow access to the spreadsheet.

Instead, any word thats duplicated twice on both password screens seems to let the user in so i need to make sure that only 1 certain password will allow access to the spreadsheets and anything else is barred from access. (The password used is Password)

Code is below, thanks in advance.

Sub ProtectAll()
Dim sh As Worksheet
Dim myPassword1 As String
myPassword1 = ("password")
Dim sInput1 As String
Dim sinput2 As String
sInput1 = InputBox("Enter password")
sinput2 = InputBox("Confirm password")
If sInput1 = sinput2 Then
MsgBox "User Can Type"
Else
MsgBox "User Cannot type"
For Each sh In ActiveWorkbook.Worksheets
sh.Protect Password:=myPassword1
Next sh
End If
End Sub

 

[taigovinda]

This should solve the immediate problem:

If sInput1 = sinput2 and sinput2=myPassword1 Then

 

[gauntletxg]

You're only checking to see if the user entered the same thing in both prompts - you aren't checking to see if it's equal to the actual password. Try something like this

Dim strInput1 As String, strInput2 As String
Dim pwd As String, sht As Worksheet
pwd = "test"

strInput1 = InputBox("Enter password", "Unprotect")
strInput2 = InputBox("Confirm password", "Unprotect")

If strInput1 = strInput2 And strInput1 = pwd Then
    ' Correct password
    On Error Resume Next
    For Each sht In ActiveWorkbook.Worksheets
        sht.Unprotect pwd
    Next
    On Error GoTo 0
Else
    ' Incorrect password
End If

 

[Smitty]

Welcome to the Board!

Noting that you'd really chap my hide for making me type the same thing twice.

 

[JakeVBA2009]

Thanks guys, brilliant solutions from both of you!

Thanks for the welcome, Smitty.