hiding shapes not working on ovals

[rickblunt]

Hello, I am trying to use the following codes to hide/show shapes on a worksheet. The weird thing is that the code for the rectangles is working perfectly, but the code for the ovals does not. I have confirmed that the shapes are "ovals" so I am at a loss as to why it will not hide the ovals. I appreciate any insights - thanks,

Sub ToggleEmergencyLights()

Dim shp As Shape

    Sheets("Device Map").Activate
    For Each shp In Sheets("Device Map").Shapes
    If shp.Type = msoShapeRectangle Then
    If shp.Name Like "*Rectangle*" Then
    If shp.Visible Then
    shp.Visible = False

Else

    shp.Visible = True

    End If
    End If
    End If
Next
End Sub

Sub ToggleFireExtinguishers()

   Dim shp As Shape
   
    Sheets("Device Map").Activate
    For Each shp In Sheets("Device Map").Shapes
    If shp.Type = msoShapeOval Then
    If shp.Name Like "*oval*" Then
    If shp.Visible Then
    shp.Visible = False

Else

    shp.Visible = True

    End If
    End If
    End If

Next
End Sub

 

[Micron]

Why worry about the type if you know the name of the shapes you want to hide?
FWIW, I just drew 2 ovals on a sheet and their type is not msoshapeoval. Their type is 1 but I'd have to look for what the mso constant equivalent would be. Or you could use a message box to get the Type value and use that instead.

When you post code, proper indentation is much appreciated.

EDIT - type 1 is a rectangle

MsoAutoShapeType enumeration (Office)

Office VBA reference topic

learn.microsoft.com

clearly they don't look like rectangles

 

[Micron]

Here's how to condense and indent that code. NOTE - text comparisons are often case sensitive. Your code may not be working because the names are not "oval" something, they are "Oval" something.

Sub ToggleFireExtinguishers()
Dim shp As Shape

For Each shp In Sheets("Device Map").Shapes
   If shp.Name Like "*Oval*" Then shp.Visible = shp.Visible = False
Next
End Sub

You could always default to using Upper case for comparisons:
If UCase(shp.Name) Like "*OVAL*" Then
Also, you don't have to Activate or even Select a sheet most of the time.

 

[rickblunt]

Here's how to condense and indent that code. NOTE - text comparisons are often case sensitive. Your code may not be working because the names are not "oval" something, they are "Oval" something.

Sub ToggleFireExtinguishers()
Dim shp As Shape

For Each shp In Sheets("Device Map").Shapes
   If shp.Name Like "*Oval*" Then shp.Visible = shp.Visible = False
Next
End Sub

You could always default to using Upper case for comparisons:
If UCase(shp.Name) Like "*OVAL*" Then
Also, you don't have to Activate or even Select a sheet most of the time.

ok - sorry to bother you, my apologies

 

[Micron]

ok - sorry to bother you, my apologies

What is that all about?