how to make this macro run through all sheets in workbook?

S

sl1990

New Member
Joined
Jun 3, 2011
Messages
20
hi how would i make this macro run though all of the sheets in my workbook i have 150 sheets named sheet1 to sheet150.

the macro looks very long but it just repeats itself looking at each row,

also is there any way of speeding this macro up

thanks in advance !

Code: 
Sub Rank_1()

Range("U3").Value = "Place"
Range("V3").Value = "Name(s)"
Range("U4").Value = "1st"
Range("V4:V100").Value = ""
On Error Resume Next
For Each cell In Range("B4:R4")
cell.Offset(1, 0).Value = Application.Rank(cell.Value, Range("B4:R4"), 0)
Next
For i = 1 To 10
For Each cell In Range("B5:R5")
If cell.Value = i Then
setPlace = setPlace & cell.Offset(-2, 0).Value & ", "
End If
Next cell
Range("V" & Rows.Count).End(xlUp).Offset(1, 0).Value = Left(setPlace, Len(setPlace) - 2)
setPlace = ""
Next i
Range("B5:R5").ClearContents
Range("V5:V100").ClearContents



Range("U6").Value = "Place"
Range("V6").Value = "Name(s)"
Range("U7").Value = "1st"
Range("V7:V100").Value = ""
On Error Resume Next
For Each cell In Range("B7:R7")
cell.Offset(1, 0).Value = Application.Rank(cell.Value, Range("B7:R7"), 0)
Next
For i = 1 To 10
For Each cell In Range("B8:R8")
If cell.Value = i Then
setPlace = setPlace & cell.Offset(-2, 0).Value & ", "
End If
Next cell
Range("V" & Rows.Count).End(xlUp).Offset(1, 0).Value = Left(setPlace, Len(setPlace) - 2)
setPlace = ""
Next i
Range("B8:R8").ClearContents
Range("V8:V100").ClearContents



Range("U9").Value = "Place"
Range("V9").Value = "Name(s)"
Range("U10").Value = "1st"
Range("V10:V100").Value = ""
On Error Resume Next
For Each cell In Range("B10:R10")
cell.Offset(1, 0).Value = Application.Rank(cell.Value, Range("B10:R10"), 0)
Next
For i = 1 To 10
For Each cell In Range("B11:R11")
If cell.Value = i Then
setPlace = setPlace & cell.Offset(-2, 0).Value & ", "
End If
Next cell
Range("V" & Rows.Count).End(xlUp).Offset(1, 0).Value = Left(setPlace, Len(setPlace) - 2)
setPlace = ""
Next i
Range("B11:R11").ClearContents
Range("V11:V100").ClearContents



Range("U12").Value = "Place"
Range("V12").Value = "Name(s)"
Range("U13").Value = "1st"
Range("V13:V100").Value = ""
On Error Resume Next
For Each cell In Range("B13:R13")
cell.Offset(1, 0).Value = Application.Rank(cell.Value, Range("B13:R13"), 0)
Next
For i = 1 To 10
For Each cell In Range("B14:R14")
If cell.Value = i Then
setPlace = setPlace & cell.Offset(-2, 0).Value & ", "
End If
Next cell
Range("V" & Rows.Count).End(xlUp).Offset(1, 0).Value = Left(setPlace, Len(setPlace) - 2)
setPlace = ""
Next i
Range("B14:R14").ClearContents
Range("V14:V100").ClearContents



Range("U15").Value = "Place"
Range("V15").Value = "Name(s)"
Range("U16").Value = "1st"
Range("V16:V100").Value = ""
On Error Resume Next
For Each cell In Range("B16:R16")
cell.Offset(1, 0).Value = Application.Rank(cell.Value, Range("B16:R16"), 0)
Next
For i = 1 To 10
For Each cell In Range("B17:R17")
If cell.Value = i Then
setPlace = setPlace & cell.Offset(-2, 0).Value & ", "
End If
Next cell
Range("V" & Rows.Count).End(xlUp).Offset(1, 0).Value = Left(setPlace, Len(setPlace) - 2)
setPlace = ""
Next i
Range("B17:R17").ClearContents
Range("V17:V100").ClearContents



Range("U18").Value = "Place"
Range("V18").Value = "Name(s)"
Range("U19").Value = "1st"
Range("V19:V100").Value = ""
On Error Resume Next
For Each cell In Range("B19:R19")
cell.Offset(1, 0).Value = Application.Rank(cell.Value, Range("B19:R19"), 0)
Next
For i = 1 To 10
For Each cell In Range("B20:R20")
If cell.Value = i Then
setPlace = setPlace & cell.Offset(-2, 0).Value & ", "
End If
Next cell
Range("V" & Rows.Count).End(xlUp).Offset(1, 0).Value = Left(setPlace, Len(setPlace) - 2)
setPlace = ""
Next i
Range("B20:R20").ClearContents
Range("V20:V100").ClearContents



Range("U21").Value = "Place"
Range("V21").Value = "Name(s)"
Range("U22").Value = "1st"
Range("V22:V100").Value = ""
On Error Resume Next
For Each cell In Range("B22:R22")
cell.Offset(1, 0).Value = Application.Rank(cell.Value, Range("B22:R22"), 0)
Next
For i = 1 To 10
For Each cell In Range("B23:R23")
If cell.Value = i Then
setPlace = setPlace & cell.Offset(-2, 0).Value & ", "
End If
Next cell
Range("V" & Rows.Count).End(xlUp).Offset(1, 0).Value = Left(setPlace, Len(setPlace) - 2)
setPlace = ""
Next i
Range("B23:R23").ClearContents
Range("V23:V100").ClearContents



Range("U24").Value = "Place"
Range("V24").Value = "Name(s)"
Range("U25").Value = "1st"
Range("V25:V100").Value = ""
On Error Resume Next
For Each cell In Range("B25:R25")
cell.Offset(1, 0).Value = Application.Rank(cell.Value, Range("B25:R25"), 0)
Next
For i = 1 To 10
For Each cell In Range("B26:R26")
If cell.Value = i Then
setPlace = setPlace & cell.Offset(-2, 0).Value & ", "
End If
Next cell
Range("V" & Rows.Count).End(xlUp).Offset(1, 0).Value = Left(setPlace, Len(setPlace) - 2)
setPlace = ""
Next i
Range("B26:R26").ClearContents
Range("V26:V100").ClearContents



Range("U27").Value = "Place"
Range("V27").Value = "Name(s)"
Range("U28").Value = "1st"
Range("V28:V100").Value = ""
On Error Resume Next
For Each cell In Range("B28:R28")
cell.Offset(1, 0).Value = Application.Rank(cell.Value, Range("B28:R28"), 0)
Next
For i = 1 To 10
For Each cell In Range("B29:R29")
If cell.Value = i Then
setPlace = setPlace & cell.Offset(-2, 0).Value & ", "
End If
Next cell
Range("V" & Rows.Count).End(xlUp).Offset(1, 0).Value = Left(setPlace, Len(setPlace) - 2)
setPlace = ""
Next i
Range("B29:R29").ClearContents
Range("V29:V100").ClearContents



Range("U30").Value = "Place"
Range("V30").Value = "Name(s)"
Range("U31").Value = "1st"
Range("V31:V100").Value = ""
On Error Resume Next
For Each cell In Range("B31:R31")
cell.Offset(1, 0).Value = Application.Rank(cell.Value, Range("B31:R31"), 0)
Next
For i = 1 To 10
For Each cell In Range("B32:R32")
If cell.Value = i Then
setPlace = setPlace & cell.Offset(-2, 0).Value & ", "
End If
Next cell
Range("V" & Rows.Count).End(xlUp).Offset(1, 0).Value = Left(setPlace, Len(setPlace) - 2)
setPlace = ""
Next i
Range("B32:R32").ClearContents
Range("V32:V100").ClearContents



Range("U33").Value = "Place"
Range("V33").Value = "Name(s)"
Range("U34").Value = "1st"
Range("V34:V100").Value = ""
On Error Resume Next
For Each cell In Range("B34:R34")
cell.Offset(1, 0).Value = Application.Rank(cell.Value, Range("B34:R34"), 0)
Next
For i = 1 To 10
For Each cell In Range("B35:R35")
If cell.Value = i Then
setPlace = setPlace & cell.Offset(-2, 0).Value & ", "
End If
Next cell
Range("V" & Rows.Count).End(xlUp).Offset(1, 0).Value = Left(setPlace, Len(setPlace) - 2)
setPlace = ""
Next i
Range("B35:R35").ClearContents
Range("V35:V100").ClearContents



Range("U36").Value = "Place"
Range("V36").Value = "Name(s)"
Range("U37").Value = "1st"
Range("V37:V100").Value = ""
On Error Resume Next
For Each cell In Range("B37:R37")
cell.Offset(1, 0).Value = Application.Rank(cell.Value, Range("B37:R37"), 0)
Next
For i = 1 To 10
For Each cell In Range("B38:R38")
If cell.Value = i Then
setPlace = setPlace & cell.Offset(-2, 0).Value & ", "
End If
Next cell
Range("V" & Rows.Count).End(xlUp).Offset(1, 0).Value = Left(setPlace, Len(setPlace) - 2)
setPlace = ""
Next i
Range("B38:R38").ClearContents
Range("V38:V100").ClearContents



Range("U39").Value = "Place"
Range("V39").Value = "Name(s)"
Range("U40").Value = "1st"
Range("V40:V100").Value = ""
On Error Resume Next
For Each cell In Range("B40:R40")
cell.Offset(1, 0).Value = Application.Rank(cell.Value, Range("B40:R40"), 0)
Next
For i = 1 To 10
For Each cell In Range("B41:R41")
If cell.Value = i Then
setPlace = setPlace & cell.Offset(-2, 0).Value & ", "
End If
Next cell
Range("V" & Rows.Count).End(xlUp).Offset(1, 0).Value = Left(setPlace, Len(setPlace) - 2)
setPlace = ""
Next i
Range("B41:R41").ClearContents
Range("V41:V100").ClearContents



Range("U42").Value = "Place"
Range("V42").Value = "Name(s)"
Range("U43").Value = "1st"
Range("V43:V100").Value = ""
On Error Resume Next
For Each cell In Range("B43:R43")
cell.Offset(1, 0).Value = Application.Rank(cell.Value, Range("B43:R43"), 0)
Next
For i = 1 To 10
For Each cell In Range("B44:R44")
If cell.Value = i Then
setPlace = setPlace & cell.Offset(-2, 0).Value & ", "
End If
Next cell
Range("V" & Rows.Count).End(xlUp).Offset(1, 0).Value = Left(setPlace, Len(setPlace) - 2)
setPlace = ""
Next i
Range("B44:R44").ClearContents
Range("V44:V100").ClearContents



Range("U45").Value = "Place"
Range("V45").Value = "Name(s)"
Range("U46").Value = "1st"
Range("V46:V100").Value = ""
On Error Resume Next
For Each cell In Range("B46:R46")
cell.Offset(1, 0).Value = Application.Rank(cell.Value, Range("B46:R46"), 0)
Next
For i = 1 To 10
For Each cell In Range("B47:R47")
If cell.Value = i Then
setPlace = setPlace & cell.Offset(-2, 0).Value & ", "
End If
Next cell
Range("V" & Rows.Count).End(xlUp).Offset(1, 0).Value = Left(setPlace, Len(setPlace) - 2)
setPlace = ""
Next i
Range("B47:R47").ClearContents
Range("V47:V100").ClearContents



Range("U48").Value = "Place"
Range("V48").Value = "Name(s)"
Range("U49").Value = "1st"
Range("V49:V100").Value = ""
On Error Resume Next
For Each cell In Range("B49:R49")
cell.Offset(1, 0).Value = Application.Rank(cell.Value, Range("B49:R49"), 0)
Next
For i = 1 To 10
For Each cell In Range("B50:R50")
If cell.Value = i Then
setPlace = setPlace & cell.Offset(-2, 0).Value & ", "
End If
Next cell
Range("V" & Rows.Count).End(xlUp).Offset(1, 0).Value = Left(setPlace, Len(setPlace) - 2)
setPlace = ""
Next i
Range("B50:R50").ClearContents
Range("V50:V100").ClearContents



Range("U51").Value = "Place"
Range("V51").Value = "Name(s)"
Range("U52").Value = "1st"
Range("V52:V100").Value = ""
On Error Resume Next
For Each cell In Range("B52:R52")
cell.Offset(1, 0).Value = Application.Rank(cell.Value, Range("B52:R52"), 0)
Next
For i = 1 To 10
For Each cell In Range("B53:R53")
If cell.Value = i Then
setPlace = setPlace & cell.Offset(-2, 0).Value & ", "
End If
Next cell
Range("V" & Rows.Count).End(xlUp).Offset(1, 0).Value = Left(setPlace, Len(setPlace) - 2)
setPlace = ""
Next i
Range("B53:R53").ClearContents
Range("V53:V100").ClearContents



Range("U54").Value = "Place"
Range("V54").Value = "Name(s)"
Range("U55").Value = "1st"
Range("V55:V100").Value = ""
On Error Resume Next
For Each cell In Range("B55:R55")
cell.Offset(1, 0).Value = Application.Rank(cell.Value, Range("B55:R55"), 0)
Next
For i = 1 To 10
For Each cell In Range("B56:R56")
If cell.Value = i Then
setPlace = setPlace & cell.Offset(-2, 0).Value & ", "
End If
Next cell
Range("V" & Rows.Count).End(xlUp).Offset(1, 0).Value = Left(setPlace, Len(setPlace) - 2)
setPlace = ""
Next i
Range("B56:R56").ClearContents
Range("V56:V100").ClearContents



Range("U57").Value = "Place"
Range("V57").Value = "Name(s)"
Range("U58").Value = "1st"
Range("V58:V100").Value = ""
On Error Resume Next
For Each cell In Range("B58:R58")
cell.Offset(1, 0).Value = Application.Rank(cell.Value, Range("B58:R58"), 0)
Next
For i = 1 To 10
For Each cell In Range("B59:R59")
If cell.Value = i Then
setPlace = setPlace & cell.Offset(-2, 0).Value & ", "
End If
Next cell
Range("V" & Rows.Count).End(xlUp).Offset(1, 0).Value = Left(setPlace, Len(setPlace) - 2)
setPlace = ""
Next i
Range("B59:R59").ClearContents
Range("V59:V100").ClearContents



Range("U60").Value = "Place"
Range("V60").Value = "Name(s)"
Range("U61").Value = "1st"
Range("V61:V100").Value = ""
On Error Resume Next
For Each cell In Range("B58:R58")
cell.Offset(1, 0).Value = Application.Rank(cell.Value, Range("B61:R61"), 0)
Next
For i = 1 To 10
For Each cell In Range("B62:R62")
If cell.Value = i Then
setPlace = setPlace & cell.Offset(-2, 0).Value & ", "
End If
Next cell
Range("V" & Rows.Count).End(xlUp).Offset(1, 0).Value = Left(setPlace, Len(setPlace) - 2)
setPlace = ""
Next i
Range("B62:R62").ClearContents
Range("V62:V100").ClearContents

End Sub
 

Excel Facts

Workdays for a market open Mon, Wed, Friday?
Yes! Use "0101011" for the weekend argument in NETWORKDAYS.INTL or WORKDAY.INTL. The 7 digits start on Monday. 1 means it is a weekend.
Sort by date Sort by votes
Simplest way might be this...
Code: 
[/FONT]
[FONT=Courier New]Option Explicit[/FONT]
[FONT=Courier New]Sub test1()
 Dim sh As Worksheet
 
 For Each sh In ThisWorkbook.Worksheets
  Call Rank_1
 Next sh
End Sub
 
Upvote 0
hi, this is probly a very stupid question but wouldnt this just loop around again and again endlessly ?
 
Upvote 0
May be you can also add
sh.activate

it will activate the sheet then run your macro and then go to next sheet and i think it should not loop forever:)
 
Upvote 0
The sh.Activate is unnecessary.

Pedie's code is a good start, but you will need to do some more work.
You need to adapt your Rank_1 subroutine to accept an input parameter, namely a worksheet object:

Code: 
Public Sub Rank_1(sh as Worksheet)
...

Then in Pedie's code, you need to do this
Code: 
Call Rank_1(sh)
inside the loop, instead of just Call Rank_1

In your Rank_1 sub, you then need to use the input parameter sh for all references to cells, ranges, etc...
First three lines would become:

Code: 
sh.Range("U3").Value = "Place"
sh.Range("V3").Value = "Name(s)"
sh.Range("U4").Value = "1st"

I hope you get the idea...
 
Upvote 0
Hermanito said:
In your Rank_1 sub, you then need to use the input parameter sh for all references to cells, ranges, etc...
First three lines would become:

Code: 
sh.Range("U3").Value = "Place"
sh.Range("V3").Value = "Name(s)"
sh.Range("U4").Value = "1st"
I hope you get the idea...
Click to expand...

Or you can you With/End With
Code: 
With sh
.Range("U3").Value = "Place"
.Range("V3").Value = "Name(s)"
.Range("U4").Value = "1st"
End With
 
Upvote 0
You must log in or register to reply here.

Similar threads

R
  • Question Question
Having Trouble getting this code in VBA to work. Attempting to download a list of PDFs
Replies
1
Views
139
6StringJazzer
6StringJazzer
P
  • Question Question
putting a snippet of code from one to another somehow
Replies
5
Views
308
Patriot2879
P
S
  • Question Question
Using Defined name and/or direct formula in VBA
2
Replies
11
Views
457
Schturman
S
T
  • Solved
Help with VBA Code in Excel
Replies
2
Views
336
tixarah
T
9518423044
  • Question Question
I want to minimize this code. It takes a lot of time to do it. Is it? It is amazon data scraping code
Replies
5
Views
280
Joe4
Joe4

Forum statistics

Threads
1,224,507
Messages
6,179,172
Members
452,893
Latest member
denay

Share this page

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top