I need help with Cancel button

[ColdGeorge]

Hi all

Cancel button of second InputBox is not working properly, please take a look at this code.
Thanks in advance.

ColdGeorge

Dim rng As Range
Dim newpdfname As String
Dim pdfpath As String

'Enter range
On Error Resume Next
Set rng = Application.InputBox(Prompt:="Please Select", Title:="Get Range", Type:=8)
On Error GoTo 0
If rng Is Nothing Then Exit Sub

'Enter name for file
On Error Resume Next
newpdfname = Application.InputBox(Prompt:="Now, Enter name for file", Title:="Get name", Type:=2)
On Error GoTo 0
If newpdfname = "" Then Exit Sub


pdfpath = ThisWorkbook.Path & "\" & newpdfname

rng.ExportAsFixedFormat Type:=xlTypePDF, _
Filename:=pdfpath, _
Quality:=xlQualityStandard, _
IncludeDocProperties:=True, _
IgnorePrintAreas:=False, _
OpenAfterPublish:=True

 

[Joe4]

Using "Cancel" on the Input Box when it is set to Text returns a FALSE value, so use this line instead to exit your code:

If newpdfname = False Then Exit Sub

Hint: An easy way to see something like this is to simply add a MsgBox that returns the value of that variable after your Exit command:

MsgBox newpdfname

and see what it returns when you click "Cancel".

 

[ColdGeorge]

Hi Joe4

Thanks

 

[Joe4]

You are welcome.

 

[ColdGeorge]

Hi all

This is how I, finally, solve my issue:

Sub crearpdf()

Dim rng As Range
Dim newpdfname As String
Dim pdfpath As String

'Enter range
On Error Resume Next
Set rng = Application.InputBox("Selecciona el Rango", _
"Selección del Rango", , , , , , 8)
On Error GoTo 0

If rng Is Nothing Then Exit Sub

'Enter name for file
On Error Resume Next
newpdfname = Application.InputBox("Introduce el Nombre del Archivo", _
"Nombramiento del Archivo", , , , , , 2)
On Error GoTo 0

If newpdfname = vbNullString Then
    MsgBox "Proceso Cancelado"
        Exit Sub
End If

If newpdfname = False Then Exit Sub

pdfpath = ThisWorkbook.Path & "\" & newpdfname

rng.ExportAsFixedFormat Type:=xlTypePDF, _
Filename:=pdfpath, _
Quality:=xlQualityStandard, _
IncludeDocProperties:=True, _
IgnorePrintAreas:=False, _
OpenAfterPublish:=True

End Sub

ColdGeorge