If...And Statement does not work

[metropol]

I have created a Userform with different date fields and descriptions fields.
I want to validate the input fields before sending a message, and have created the following macro.

--------------------------------------
DIM TxBeskr as String
DIM TxStart as Date
DIM TxEnd as Date
DIM TxWBS as String
--------------------------
Private sub command_Send_message()

If TxStart > "" And TxEnd > "" And TxWBS > "" And TxBeskr > "" Then
If IsDate(TxStart) = True Then
If IsDate(TxEnd) = True Then

etc

End if
msgbox "You have not entered any data in the userform"

-----------------------------------------------
The problem ist that the first IF/AND statment does not work.

If there has been no values registred in the userform, it should just go to end if and show the message.

BUT. If there has been values registred, the next step should be If IsDate... But it does not recognize the values in the userform and goes directly to the End IF of the first IF statement.

It is it a problem with the variables and declarations?

 

[StevenD]

Hi Metropol,

Maybe try this.

If TxStart <> "" And TxEnd <> "" And TxWBS <> "" And TxBeskr <> "" Then

Hope this helps.

 

[metropol]

Hi Steven

Tried it, but unfortunately it didn't work. It does not recognize the values in the form in the IF statement.

 

[Norie]

Why are you using the more than operator?

And why are you using the Date data type?

Also why have you declared variables and not given them any values?

If TxBeskr etc are controls on the userform just refer to them directly.

' first see if anything is entered in the control
If Me.TxStart.Value = "" Then 
      MsgBox "Please enter something for the start date"
      Exit Sub
End If
 
' now see if it's a date
If Not(IsDate(Me.TxStart.Value)) Then
      Msgbox "Please enter a date for the start date.
      Me.TxStart.Value = ""
      Me.TxStart.SetFocus
End If

By the way you could validate each individual control on it's own rather than trying to do them in one go.

For example.

Private Sub TxStart(Cancel As Boolean)
     If Not(IsDate(TxStart)) Then
          MsgBox "Please enter a date"
          Cancel = True
     End If

 

[StevenD]

Have you assigned the number specific area of the text form into your variables?

i.e

TxStart = yourUserForm.txtTxStart.Text

 

[metropol]

Have you assigned the number specific area of the text form into your variables?

i.e

TxStart = yourUserForm.txtTxStart.Text

Yes. During debugging I can see that TxStart has a value.

 

[metropol]

Why are you using the more than operator?

I was trying to be more rational in my coding (and of course I culd have out tricked my self)

Ex. If there was an illegal value in the TxStart (ex "2009-3f-ff") Then the value should be cleard, the background highlighted red, and a messagebox should pop-up. The same for TxEnd.

BUT, If there where no values at all in the userform, it shold not send a mail just tell the user with a msgbox that there where no entries in the userform.

 

[Norie]

You shouldn't need variables, refer to the controls on the userform directly.

 

[metropol]

You shouldn't need variables, refer to the controls on the userform directly.

Ok. Thanks