if function Macro not working

[blzalewski]

Can anybody tell me why this function is not working:

Function CalcValue(pVal As String) As Long

If pVal = "xy1267" Then
CalcValue = "fdsfs, dfs"

ElseIf pVal = "xy1671" Then
CalcValue = "xxx, ysdf"

ElseIf pVal = "me2742" Then
CalcValue = "asdfsa, dsf"

ElseIf pVal = "qw1352" Then
CalcValue = "asda, asdf"

ElseIf pVal = "po7571" Then
CalcValue = "sada, asdas"

ElseIf pVal = "qw3127" Then
CalcValue = "asda, asdasda"

ElseIf pVal = "qw9898" Then
CalcValue = "sda,fsdsd"

ElseIf pVal = "sd2458" Then
CalcValue = "sadro, sdlis"

ElseIf pVal = "bq9632" Then
CalcValue = "sdada, sad"

ElseIf pVal = "gc2536" Then
CalcValue = "sdaf, sdaas"

ElseIf pVal = "pp8187" Then
CalcValue = "qw, sda"

Else
CalcValue = "ERROR: Not in CalcValue IF list"
End If

End Function

 

[schielrn]

Whats not working? Are you always getting the ERROR message in the if?

You have the function defined as a long when you are trying to return a string?

Change:

Function CalcValue(pVal As String) As Long

To:

Function CalcValue(pVal As String) As String

Hope that helps.