If Range.Value = Yes then copy data to LOG RECORD - Records are overwriting

bemp87

Board Regular
Joined
Dec 10, 2016
Messages
102
Hi Community,

I have a VBA macro for a log record that copies information from a submission form and pastes it in a Log Record data file based on a IF condition. THe condition is partially working where if the condition is true then the data is copied to the log record, But when i try and process a second form it just overwrites the first submission on the log record instead of processing to the next row as it should and did prior to including the IF condition. Any guidance?

Code provided below:
Code:
Public Sub Update()

If Range("AH9").Value = "Yes" Then


Application.ScreenUpdating = False


ActiveSheet.Unprotect


Dim answer As Integer


Dim LUR As Long 'Last Used Row
LUR = Sheets("Data File").Range("A65000").End(xlUp).Offset(1, 0).Row


' This copies data from the Entry Form to the Log Record.


Const ms As Double = 0.000000011574


    Range("J9").Copy 'Name
    Sheets("Data File").Range("B" & LUR).PasteSpecial Paste:=xlPasteValues
    Application.Wait (Now + ms * 250)
'This saves the workbook after you hit the update button
ActiveWorkbook.Save




Application.ScreenUpdating = True
MsgBox "Your complaint case has been submitted."


On Error Resume Next


ElseIf Range("AH9").Value Is Nothing Then


On Error GoTo 0


End If


End Sub
 

Excel Facts

Show numbers in thousands?
Use a custom number format of #,##0,K. Each comma after the final 0 will divide the displayed number by another thousand
Try:
Code:
Public Sub Update()
    If Range("AH9").Value = "Yes" Then
        Application.ScreenUpdating = False
        ActiveSheet.Unprotect
        Const ms As Double = 0.000000011574
        Range("J9").Copy 'Name
        Sheets("Data File").Cells(Sheets("Data File").Rows.Count, "B").End(xlUp).Offset(1, 0).PasteSpecial Paste:=xlPasteValues
        Application.Wait (Now + ms * 250)
        'This saves the workbook after you hit the update button
        ActiveWorkbook.Save
        Application.ScreenUpdating = True
        MsgBox "Your complaint case has been submitted."
        On Error Resume Next
    ElseIf Range("AH9").Value Is Nothing Then
        On Error GoTo 0
    End If
End Sub
 
Upvote 0
with this instruction you are counting the rows according to column "A", but you are pasting the data in column "B"

Code:
LUR = Sheets("Data File").Range("[B][COLOR=#0000ff]A[/COLOR][/B]65000").End(xlUp).Offset(1, 0).Row

then you have to change the count to column "B"

Code:
LUR = Sheets("Data File").Range("[B][COLOR=#0000ff]B[/COLOR][/B]65000").End(xlUp).Offset(1, 0).Row
 
Upvote 0
The problem is that you are adding info to col B, but checking col A for the last row.
This
Code:
LUR = Sheets("Data File").Range("A65000").End(xlUp).Offset(1, 0).Row
should be
Code:
LUR = Sheets("Data File").Range("B"& rows.count).End(xlUp).Offset(1, 0).Row

You can also delete these three lines as they don't do anything
Code:
On Error Resume Next


ElseIf Range("AH9").Value Is Nothing Then


On Error GoTo 0
 
Last edited:
Upvote 0
If the active sheet is protected and you are only going to copy the data to paste in "Data File" sheet, then it is not necessary to unprotect sheet.
The code would look like this:


Code:
Public Sub Update()
    If Range("AH9").Value = "Yes" Then
        Application.ScreenUpdating = False
        Dim LUR As Long 'Last Used Row
        LUR = Sheets("Data File").Range("B" & Rows.Count).End(xlUp).Offset(1, 0).Row
        Range("J9").Copy 'Name
        Sheets("Data File").Range("B" & LUR).PasteSpecial Paste:=xlPasteValues
        ActiveWorkbook.Save
        Application.ScreenUpdating = True
        MsgBox "Your complaint case has been submitted."
    End If
End Sub
 
Upvote 0

Forum statistics

Threads
1,214,935
Messages
6,122,337
Members
449,077
Latest member
Jocksteriom

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top