IF THEN error

[ProphetofProfit]

IF THEN is the problem, I don't know why. I'm not a professional coder, I just do this stuff for the thrills . I'm trying to find the value of Sheets("Odds").Cells(r, 18).Value in the sheet "Get Odds" and then copy the two cells to the right back into "Odds".

You can see that I'm running another macro in this macro, which outputs the cells which I need to copy and paste. This other macro takes about 5 seconds to complete, will my macro automatically give this "Cmdcalculate_click" macro enough time to finish?

------------------------
Sub BackTest()
Dim i
Dim r
For r = Sheets("Summary").Range("E1") To Sheets("Odds").Range("E2")

'Copy predicted goals to "Get Odds"

Sheets("Get Odds").Cells(1, 3).Value = Sheets("Odds").Cells(r, 7).Value
Sheets("Get Odds").Cells(2, 3).Value = Sheets("Odds").Cells(r, 8).Value

'Run Macro

Application.Run "CmdCalculate_Click"

'Copy over and under 2.5 probabilities

Sheets("Odds").Cells(r, 11).Value = Sheets("Get Odds").Range("B19").Value
Sheets("Odds").Cells(r, 12).Value = Sheets("Get Odds").Range("B20").Value

'Search for the asian handicap in "Get Odds"

For i = Sheets("Get Odds").Range("A32") To Sheets("Get Odds").Range("A56")
If
Sheets("Get Odds").Cells(i, 1).Value = Sheets("Odds").Cells(r, 18).Value
Then
Sheets("Odds").Cells(r, 21).Value = Sheets("Get Odds").Cells(i, 2).Value
Sheets("Odds").Cells(r, 22).Value = Sheets("Get Odds").Cells(i, 3).Value
Else
Next i
Next r
End Sub
--------------------

 

[MrKowz]

You need to keep the conditional and "Then" on the same line as the If.

Sub BackTest()
Dim i
Dim r
For r = Sheets("Summary").Range("E1") To Sheets("Odds").Range("E2")

'Copy predicted goals to "Get Odds"
 
  Sheets("Get Odds").Cells(1, 3).Value = Sheets("Odds").Cells(r, 7).Value
  Sheets("Get Odds").Cells(2, 3).Value = Sheets("Odds").Cells(r, 8).Value

'Run Macro

  Application.Run "CmdCalculate_Click"

'Copy over and under 2.5 probabilities
 
  Sheets("Odds").Cells(r, 11).Value = Sheets("Get Odds").Range("B19").Value
  Sheets("Odds").Cells(r, 12).Value = Sheets("Get Odds").Range("B20").Value

'Search for the asian handicap in "Get Odds"

For i = Sheets("Get Odds").Range("A32") To Sheets("Get [COLOR=Black]Odds").Range("A56")
[/COLOR] [COLOR=Black]If Sheets("Get Odds").Cells(i, 1).Value = Sheets("Odds").Cells(r, 18).Value[/COLOR][COLOR=Black] Then[/COLOR]
  Sheets("Odds").Cells(r, 21).Value = Sheets("Get Odds").Cells(i, 2).Value
  Sheets("Odds").Cells(r, 22).Value = Sheets("Get Odds").Cells(i, 3).Value
End If
Next i
Next r
End Sub

 

[ProphetofProfit]

Thanks, that solved it.

My next error is this:

Application.Run "CmdCalculate_Click"

I'm trying to run another macro, which I didn't create, which is in the same worksheet, and works fine. Here is the code for this other macro:

Private Sub CmdCalculate_Click()
    'initialise values
    For i = 0 To 11
        For j = 0 To 11

But there is an error:

Run-time error '1004':

Application-defined or object defined error.