if/then problems

[rickblunt]

Greetings, I thought I had a good handle on If/Then's but apparently not. I am using the code below in a userform to look for missing entries in a WS, and everything with the first Msgbox works as it is supposed to. I decided to add in the second Msgbox and now no matter what value is in (i,7) I always get the second Msgbox. I can't figure out what I am missing, I am guessing that "Else" is the wrong one to use? I appreciate any insight - thanks,

Private Sub RepairButton_Click()

    Dim i As Long
    Dim Lastrow As Long
    
    Worksheets("Device List").Activate
    
    Lastrow = Cells(Rows.Count, "A").End(xlUp).Row
    
    For i = 1 To Lastrow
        If Cells(i, 8).Value = "FAIL" And Cells(i, 7).Value = "" Then
        
        MsgBox "Repair comments required"
                
            RepairForm.Show

     Else
            
        MsgBox "No repairs are needed"
            
        Exit For
      End If
    Next
End Sub

 

[Andy B]

Hi, you appear to be exiting the macro as soon as you hit a "no repair" line.
I assume you only wish to exit when you launch the repair form therefor the "Exit For" command should be above the 'Else' not after it.

 

[rickblunt]

not exactly, but I had tried that already I believe that the issue is because of the usage of the "For/Exit For" routine. I think that using Else with that is not appropriate. I rewrote the code to use a reference cell instead and it is working as a typical If/Then statement does.

I appreciate the input.

Private Sub RepairButton_Click()
    
    Worksheets("Device List").Activate
    
        If Sheets("Coding").Range("H8").Value > 0 Then                                           
            RepairForm.Show            
        Else        
            MsgBox "No further repair comments are needed"
            
    End If
    
End Sub