IF - Then statement not meeting criteria

[aberenguel]

Here's my code
Sub balance_transfer()
' balance_transfer Macro
' Written 09/13/2006 by Anthony Berenguel
'

'
Sheets("OUTPUT TRANSFER").Select

If Range("az235").Select = "FALSE" Then
Call rebalance_1
ElseIf Range("AZ235").Select = "FALSE" Then
Call rebalance_2
ElseIf Range("AZ235").Select = "FALSE" Then
Call rebalance_3
End If

End Sub

I have typed FALSE in cell AZ235 of the output transfer sheet. Therefore excel should call the rebalance_1() macro. But it doesn't. When i step through this code it never calls any of the rebalance macros even though AZ235 equals FALSE.

Please help,
Anthony Berenguel

 

[pgc01]

Hi Anthony

You are testing the text "FALSE". Maybe AZ235 has the logical value FALSE and not the text "FALSE"?

If AZ235 has the logical value FALSE use

If Not Range("AZ235").Value Then 
    Call rebalance_1
    Call rebalance_2
    Call rebalance_3
End If

If indeed AZ235 has the text "FALSE", no need for the Select

If Range("AZ235").Value="FALSE" Then 
    Call rebalance_1
    Call rebalance_2
    Call rebalance_3
End If

Hope this helps
PGC

 

[pgc01]

P. S.

Another solution, that will work in both cases, is to use the text property.

If Range("AZ235").Text="FALSE" Then 
    Call rebalance_1 
    Call rebalance_2 
    Call rebalance_3 
End If

It works fine but is ambiguous, and so not recommended.

 

[erik.van.geit]

Hi,

you have "Select" which makes it always TRUE
you see ?

Sub test()
Range("A1") = True
MsgBox Range("A1").Select
Range("A1") = False
MsgBox Range("A1").Select
End Sub

kind regards,
Erik

 

[pgc01]

Thank you, Erik, You are right. If the selection is successful it returns True no matter what is the value of the cell. In my case it's clear that the phrase "The mind is quicker than the hand" does not apply.

 

[aberenguel]

thanks everyone!

I have figured it out with all your help. The SELECT part was throwing me off. But thanks again!

Anthony